Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5726 card changes #5727 button space issue #5733

Merged
merged 8 commits into from
May 3, 2023
Merged

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Apr 20, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 4ca5d3c

This pull request improves the user interface and design of the NeoNftCard component by making the whole card clickable and navigable to the nft details page, and by changing the color of the collection name link to match the theme and contrast better on hover. These changes affect the files NeoNftCard.vue and _collection-card.scss.

🤖 Generated by Copilot at 4ca5d3c

nuxt-link expands
card becomes more clickable
spring breeze of UX

@prachi00 prachi00 requested a review from a team as a code owner April 20, 2023 00:35
@prachi00 prachi00 requested review from vikiival and Jarsen136 and removed request for a team April 20, 2023 00:35
@kodabot
Copy link
Collaborator

kodabot commented Apr 20, 2023

SUCCESS @prachi00 PR for issue #5726 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8312219
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6451e899facb9700085b9490
😎 Deploy Preview https://deploy-preview-5733--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 20, 2023
@prachi00 prachi00 changed the title #5726 card changes #5726 card changes #5727 button space issue Apr 20, 2023
@Jarsen136 Jarsen136 requested a review from exezbcz April 20, 2023 04:04
@exezbcz
Copy link
Member

exezbcz commented Apr 20, 2023

the nft name should not change with the hover
canary
image
deploy
image

@prachi00 prachi00 requested a review from roiLeo April 21, 2023 16:35
@exezbcz
Copy link
Member

exezbcz commented Apr 24, 2023

make the whole card clickable - like the collection card - cursor to pointer in the whole card container

@exezbcz exezbcz added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 24, 2023
@prachi00
Copy link
Member Author

https://deploy-preview-5733--koda-canary.netlify.app

@exezbcz it is clickable though? this part
Screen Shot 2023-04-24 at 9 47 03 AM

@exezbcz
Copy link
Member

exezbcz commented Apr 24, 2023

the nft name should not change with the hover canary image deploy image

yeah, but the text should not change to its hover color
image

@prachi00
Copy link
Member Author

the nft name should not change with the hover canary image deploy image

yeah, but the text should not change to its hover color image

done @exezbcz

@prachi00
Copy link
Member Author

can we merge this one now?

@roiLeo
Copy link
Contributor

roiLeo commented Apr 28, 2023

can we merge this one now?

I still see nuxt-link

@prachi00
Copy link
Member Author

can we merge this one now?

I still see nuxt-link

removed from there as well

@roiLeo roiLeo removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 28, 2023
@prachi00
Copy link
Member Author

prachi00 commented May 3, 2023

can we merge this?

@codeclimate
Copy link

codeclimate bot commented May 3, 2023

Code Climate has analyzed commit 8312219 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 6ebd19c into main May 3, 2023
19 checks passed
@vikiival vikiival deleted the feat-small-card-changes branch May 3, 2023 15:55
@vikiival
Copy link
Member

vikiival commented May 3, 2023

pay 15 usd

@yangwao
Copy link
Member

yangwao commented May 3, 2023

😍 Perfect, I’ve sent the payout
💵 $15 @ 28.13 USD/KSM ~ 0.533 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x8ccefea8b3e56ff306fd35231730e4173e1566d314adc2747419b5163650bb91

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cards small issues
6 participants