Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: square icons in search result item #5738

Merged
merged 4 commits into from
Apr 20, 2023
Merged

feat: square icons in search result item #5738

merged 4 commits into from
Apr 20, 2023

Conversation

floyd-li
Copy link
Member

@floyd-li floyd-li commented Apr 20, 2023 •
edited by ghost

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

image

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at c153e31

Removed unnecessary border and border-radius styles from search result images. Simplified the skeleton loading element and added a conditional border class to the media-left element. Affected files: components/search/SearchResultItem.vue and styles/components/_search.scss.

🤖 Generated by Copilot at c153e31

media-left adds
border when not loading now
simpler BasicImage

@floyd-li floyd-li requested a review from a team as a code owner April 20, 2023 11:19
@floyd-li floyd-li requested review from vikiival and Jarsen136 and removed request for a team April 20, 2023 11:19
@kodabot
Copy link
Collaborator

kodabot commented Apr 20, 2023

SUCCESS @floyd-li PR for issue #5725 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 20, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c153e31
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64415f91fa013400088992e9
😎 Deploy Preview https://deploy-preview-5738--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 20, 2023

AI-Generated Summary: This pull request contains two patches. The first patch modifies the SearchResultItem.vue component to remove the rounded attribute from the BasicImage component, effectively changing the icons in search result items to be square instead of circular. Also, the redundant border-radius: 50%; styling is removed from _search.scss. The second patch adds border-radius: 0%; to the .image-outline class in _search.scss to ensure square-shaped icons.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 20, 2023
@yangwao
Copy link
Member

yangwao commented Apr 20, 2023

@exezbcz 👀

image

@yangwao yangwao requested a review from exezbcz April 20, 2023 11:36
@yangwao yangwao added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 20, 2023
@yangwao
Copy link
Member

yangwao commented Apr 20, 2023

Loading preview for NFTs in search doesn't work, but when you click on item it loads well

image

Jarsen136
Jarsen136 reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

styles/components/_search.scss Outdated Show resolved Hide resolved
@yangwao yangwao mentioned this pull request Apr 20, 2023
Closed
@yangwao
Copy link
Member

yangwao commented Apr 20, 2023

@floyd-li if you want to make this one here

@floyd-li @Jarsen136
Update styles/components/_search.scss
fecd308 
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
roiLeo
roiLeo suggested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update skeleton too please?

(remove circle prop)

styles/components/_search.scss Outdated
@@ -256,7 +256,7 @@
}

.image-outline {
border-radius: 50%;
border-radius: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or remove it, if not used?

vikiival
vikiival reviewed Apr 20, 2023
View reviewed changes
styles/components/_search.scss Outdated
@@ -256,7 +256,7 @@
}

.image-outline {
border-radius: 50%;
border-radius: 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border-radius: 0;

@exezbcz
Copy link
Member

exezbcz commented Apr 20, 2023

make it perfect square please
image

@codeclimate
Copy link

codeclimate bot commented Apr 20, 2023

Code Climate has analyzed commit c153e31 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Apr 20, 2023

pay 30 usd
perfect

@yangwao
Copy link
Member

yangwao commented Apr 20, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 33.33 USD/KSM ~ 0.9 $KSM
🧗 EZiu1PjV2j2JHKxY6mHnFwwCRCoV27uHKQSkKXATSh1srJT
🔗 0x56dc395445df2d6332c95400c0afb126d85c3de5a3d9d86d2573ad32a3143bc0

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 20, 2023
@yangwao yangwao mentioned this pull request Apr 20, 2023
Merged
16 tasks
@vikiival vikiival merged commit e84d8c9 into kodadot:main Apr 20, 2023
17 checks passed
This was referenced Apr 20, 2023
Closed
Closed
Closed
Closed
@floyd-li floyd-li deleted the feat/square-icons branch October 8, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 left review comments

@roiLeo roiLeo roiLeo requested changes

@vikiival vikiival vikiival approved these changes

@exezbcz exezbcz exezbcz approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Square icons for results in searchbar
7 participants
@floyd-li @kodabot @yangwao @exezbcz @roiLeo @vikiival @Jarsen136