Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5757 search empty text #5778

Merged
merged 4 commits into from
Apr 25, 2023
Merged

#5757 search empty text #5778

merged 4 commits into from
Apr 25, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Apr 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2023-04-23 at 7 31 44 PM

Copilot Summary

🤖 Generated by Copilot at 2fff809

Add feedback messages for empty search suggestions. The SearchSuggestion component now displays localized messages when no suggestions are found for a given query, using margin classes for styling.

🤖 Generated by Copilot at 2fff809

When the search box has no suggestions
It shows some feedback messages
They are localized
And nicely sized
With margin classes for the edges

@prachi00 prachi00 requested a review from a team as a code owner April 24, 2023 02:33
@prachi00 prachi00 requested review from roiLeo and Jarsen136 and removed request for a team April 24, 2023 02:33
@kodabot
Copy link
Collaborator

kodabot commented Apr 24, 2023

WARNING @prachi00 PR for issue #5757 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5757

@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 923bc11
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6447751c5f34290008f97b48
😎 Deploy Preview https://deploy-preview-5778--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 24, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 24, 2023

AI-Generated Summary: This pull request addresses issue #5757 by adding empty text for search results in the SearchSuggestion.vue component. It introduces two new messages in the en.json locale file: collectionNotFound and nftNotFound, which are displayed when no collection or NFT suggestions are found, respectively. The changes result in the addition of 10 new lines and modification of 2 lines in the code.

locales/en.json Outdated Show resolved Hide resolved
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing dobble quote arround search value

otherwise wfm ✅

vikiival and others added 2 commits April 24, 2023 18:56
Co-authored-by: roiLeo <medina.leo42@gmail.com>
locales/en.json Outdated Show resolved Hide resolved
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Apr 25, 2023
@codeclimate
Copy link

codeclimate bot commented Apr 25, 2023

Code Climate has analyzed commit 923bc11 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Apr 25, 2023

Only thing is that we show this... and then on client arrives payload.
Handle pending search better

Screen.Recording.2023-04-25.at.13.46.59.mov

@yangwao
Copy link
Member

yangwao commented Apr 25, 2023

pay 20 usd

@yangwao yangwao merged commit aef02c1 into main Apr 25, 2023
17 of 20 checks passed
@yangwao yangwao deleted the feat-searhc-text branch April 25, 2023 11:48
@yangwao
Copy link
Member

yangwao commented Apr 25, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 29.93 USD/KSM ~ 0.668 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xaf51ec5439b76854dc55d5018776b0b3a2da00e2ea2b17f61270664b0e0494b4

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 25, 2023
@yangwao yangwao mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank state for search bar
6 participants