Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix e2e test for simple mint estimated value #5794

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Apr 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 49675b4

Improved the BasicInput component prop handling and simplified the currency formatting in the SimpleMint component. These changes enhance the usability and maintainability of the form components.

🤖 Generated by Copilot at 49675b4

We are the masters of the BasicMoney
We format the currency as we please
We wield the power of the value prop
We clear the input or leave it empty

@kodabot
Copy link
Collaborator

kodabot commented Apr 24, 2023

WARNING @preschian PR for issue #3966 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #3966

@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f5da559
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6448f9acb82c760008c3f4b9
😎 Deploy Preview https://deploy-preview-5794--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 24, 2023

AI-Generated Summary: This pull request includes changes to fix the end-to-end test for Simple Mint's estimated value feature. It modifies SimpleMint.vue, BasicInput.vue, and rmrk-simple-mint.cy.ts. Specifically, it updates the import path for the Money component in SimpleMint.vue and adjusts the value prop definition in BasicInput.vue. In the rmrk-simple-mint.cy.ts test file, it enhances the assertions involving the fee display by removing whitespace and testing against the expected value.

@reviewpad reviewpad bot added the small Pull request is small label Apr 24, 2023
@preschian preschian marked this pull request as ready for review April 24, 2023 22:43
@preschian preschian requested a review from a team as a code owner April 24, 2023 22:43
@preschian preschian requested review from vikiival and Jarsen136 and removed request for a team April 24, 2023 22:43
@floyd-li floyd-li mentioned this pull request Apr 25, 2023
17 tasks
@codeclimate
Copy link

codeclimate bot commented Apr 26, 2023

Code Climate has analyzed commit f5da559 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe not related but
Capture d’écran 2023-04-26 à 2 11 40 PM

otherwise lgtm ✅

@vikiival vikiival merged commit 6687ea6 into main Apr 27, 2023
19 of 20 checks passed
@vikiival vikiival deleted the test/adjust-simple-mint-estimated branch April 27, 2023 12:32
@yangwao yangwao mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple mint shows 0 fees for minting
5 participants