Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix identity display name #5802

Merged
merged 4 commits into from
May 2, 2023
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Apr 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • use proper prefix on useApi()
  • fix error 400 on rmrk gallery detail

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at efa8357

Optimized the nftById query and refactored the useApi function to improve the performance and maintainability of the NFT gallery.

🤖 Generated by Copilot at efa8357

We're sailing on the web with our useApi hook
We fetch the chain endpoint with the usePrefix nook
We trim the nftById query to make it nice and lean
And we render the NftDetail component on the screen

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 24, 2023

AI-Generated Summary: This pull request includes changes to fix the identity display name issue. It modifies three files: composables/useApi.ts, queries/subsquid/rmrk/nftById.graphql, and tests/cypress/e2e/components/identity.cy.ts. In useApi.ts, the URL prefix is updated to use the correct computed value. In nftById.graphql, redundant parent-related fields are removed. Finally, in identity.cy.ts, network idle is properly waited for, and the identity-related elements are tested for correct content and attributes.

@reviewpad reviewpad bot added the small Pull request is small label Apr 24, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 24, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@preschian preschian changed the base branch from test/adjust-simple-mint-estimated to main April 24, 2023 22:48
@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 14520f7
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645095711de1e60008718b8c
😎 Deploy Preview https://deploy-preview-5802--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian changed the base branch from main to test/adjust-simple-mint-estimated April 24, 2023 23:16
Base automatically changed from test/adjust-simple-mint-estimated to main April 27, 2023 12:32
@Jarsen136 Jarsen136 mentioned this pull request Apr 27, 2023
17 tasks
@preschian preschian marked this pull request as ready for review May 2, 2023 04:45
@preschian preschian requested a review from a team as a code owner May 2, 2023 04:45
@preschian preschian requested review from roiLeo and daiagi and removed request for a team May 2, 2023 04:45
@codeclimate
Copy link

codeclimate bot commented May 2, 2023

Code Climate has analyzed commit 14520f7 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 2, 2023
@preschian preschian merged commit 4857318 into main May 2, 2023
19 checks passed
@preschian preschian deleted the test/adjust-identity-display-name branch May 2, 2023 07:47
@yangwao yangwao mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants