Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add qa-quild to pipe #5810

Merged
merged 1 commit into from
Apr 25, 2023
Merged

add qa-quild to pipe #5810

merged 1 commit into from
Apr 25, 2023

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented Apr 25, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

copilot:summary

copilot:poem

@yangwao yangwao requested a review from a team as a code owner April 25, 2023 12:59
@yangwao yangwao requested review from preschian and roiLeo and removed request for a team April 25, 2023 12:59
@netlify
Copy link

netlify bot commented Apr 25, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6cb63c2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6447ce9de7022e0008179810
😎 Deploy Preview https://deploy-preview-5810--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao yangwao changed the title add qa-builds add qa-quild to pipe Apr 25, 2023
@yangwao yangwao merged commit 793cf86 into main Apr 25, 2023
12 of 15 checks passed
@yangwao yangwao deleted the yangwao-patch-1 branch April 25, 2023 12:59
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 25, 2023

AI-Generated Summary: This pull request updates the .github/CODEOWNERS file by adding the @kodadot/qa-guild as a new code owner alongside the existing @kodadot/code-review-guild.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 25, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 25, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

roiLeo
roiLeo reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-04-25 at 17-44-03 add qa-quild to pipe by yangwao · Pull Request #5810 · kodadot_nft-gallery

@yangwao yangwao mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo left review comments

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yangwao @roiLeo