Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: NeoSkeleton component #5822

Merged
merged 2 commits into from
Apr 28, 2023
Merged

refactor: NeoSkeleton component #5822

merged 2 commits into from
Apr 28, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Apr 27, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 26893b1

The pull request replaces various skeleton components from Buefy and Oruga UI with a custom NeoSkeleton component in several components of the app. This improves the UI consistency and customization of the skeleton placeholders for loading data. The affected components include GalleryItemActivityTable, HotTable, TopCollections, Name, SalesTable, SearchResultItem, SeriesTable, LabeledText, BasicImage, and SpotlightTable.

🤖 Generated by Copilot at 26893b1

Sing, O Muse, of the glorious pull request
That brought to the app a new look and zest
By replacing the old b-skeleton component
With the custom NeoSkeleton, splendid and potent.

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 27, 2023 18:38
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team April 27, 2023 18:38
@kodabot
Copy link
Collaborator

kodabot commented Apr 27, 2023

SUCCESS @Jarsen136 PR for issue #5816 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 27, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 96a67d6
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/644b9a1e20c5d80008ca580d
😎 Deploy Preview https://deploy-preview-5822--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Apr 27, 2023

Code Climate has analyzed commit 26893b1 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 27, 2023

AI-Generated Summary: This pull request includes changes to various Vue components, mainly focusing on replacing the <b-skeleton> component with a custom implementation called <NeoSkeleton>. The key changes span across files such as SpotlightTable.vue, GalleryItemActivityTable.vue, Detail.vue, HotTable.vue, SearchResultItem.vue, SalesTable.vue, Name.vue, and BasicImage.vue, among others. A new NeoSkeleton.vue component has been introduced, which is a wrapper around the OSkeleton component from the Oruga UI library. The component takes various props and has styles imported from NeoSkeleton.scss. Additionally, a new NeoSkeleton.story.vue file has been created containing a storybook story for the NeoSkeleton component, showcasing four different variants. These changes improve the code by using a more appropriate skeleton component with better customization options.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Apr 27, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect this is exactly what I was excepting.
✅ wfm, just need to resolve conflict

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Apr 28, 2023
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okish

@vikiival vikiival enabled auto-merge April 28, 2023 07:38
@vikiival vikiival merged commit 845d664 into kodadot:main Apr 28, 2023
8 of 12 checks passed
@yangwao yangwao mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: NeoSkeleton component
4 participants