Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep activeTab in url #5828

Merged
merged 2 commits into from
May 10, 2023
Merged

fix: keep activeTab in url #5828

merged 2 commits into from
May 10, 2023

Conversation

Gavin-Gong
Copy link
Contributor

@Gavin-Gong Gavin-Gong commented Apr 28, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at d89a812

Added tab switching and persistence feature to CreateMixin for collection and NFT creation. Used Watch, onTabChange, and created to implement this feature in utils/mixins/createMixin.ts.

🤖 Generated by Copilot at d89a812

CreateMixin is the master of your fate
Switch and persist the tabs you create
With Watch and onTabChange you dominate
The created hook unleashes your power and hate

@Gavin-Gong Gavin-Gong requested a review from a team as a code owner April 28, 2023 12:45
@Gavin-Gong Gavin-Gong requested review from preschian and roiLeo and removed request for a team April 28, 2023 12:45
@netlify
Copy link

netlify bot commented Apr 28, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 79a2b55
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6459fe2aadedfa00088356d4
😎 Deploy Preview https://deploy-preview-5828--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 28, 2023

AI-Generated Summary: This pull request introduces changes to the createMixin.ts file to keep the activeTab in the URL. It adds a Watch decorator to handle the tab change and update the URL accordingly. Moreover, on the component's creation, it reads the tab value from the URL query parameter and updates the activeTab accordingly.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 28, 2023
@yangwao
Copy link
Member

yangwao commented Apr 30, 2023

@kodadot/qa-guild

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ wfm

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 5, 2023
@codeclimate
Copy link

codeclimate bot commented May 9, 2023

Code Climate has analyzed commit 79a2b55 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels May 10, 2023
@yangwao
Copy link
Member

yangwao commented May 10, 2023

pay 30 usd

kthx!

@yangwao
Copy link
Member

yangwao commented May 10, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 26.23 USD/KSM ~ 1.144 $KSM
🧗 GqheyaQ3c8SFBJYorTXyLW6jvLXKNAXzbad77NXoLYJBXXs
🔗 0x54e7b4fe69910e6e1ed913443105957dec65aa969d9efd1cabba297a70ecc773

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 10, 2023
@yangwao yangwao merged commit 111688b into kodadot:main May 10, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refreshing Create - NFT page kicks me back to Create - Collection page
4 participants