Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5772 nsfw changes in gallery #5844

Merged
merged 9 commits into from
May 10, 2023
Merged

#5772 nsfw changes in gallery #5844

merged 9 commits into from
May 10, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented May 2, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screen Shot 2023-05-01 at 8 42 24 PM

Copilot Summary

🤖 Generated by Copilot at 4aab639

This pull request adds support for NSFW media items in the gallery, by blurring them and allowing the user to toggle the blur. It modifies the GalleryItem, MediaItem, and GalleryItemDescription components to use the NSFW trait as a prop and an icon.

🤖 Generated by Copilot at 11e5d62

Blinded by the lewdness, you can't see the truth
isLewd is the judge, the traitor and the proof
Reveal the hidden content, with a click of fate
But beware of the console.log, it might be too late

@prachi00 prachi00 requested a review from a team as a code owner May 2, 2023 03:42
@prachi00 prachi00 requested review from vikiival and Jarsen136 and removed request for a team May 2, 2023 03:42
@kodabot
Copy link
Collaborator

kodabot commented May 2, 2023

SUCCESS @prachi00 PR for issue #5772 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 2, 2023
@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e878ca1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645821667689dc00083d82f6
😎 Deploy Preview https://deploy-preview-5844--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 2, 2023

AI-Generated Summary: This pull request introduces changes related to the handling of NSFW (Not Safe For Work) content in the gallery. It modifies 3 files: GalleryItem.vue, GalleryItemDescription.vue, and MediaItem.vue. The patch adds a method to display an explicit content warning and blur the content for NSFW media items. Users are required to confirm their age and consent before revealing the content. Additionally, it updates the logic to only show the full-screen option if the content is not NSFW.

@prachi00
Copy link
Member Author

prachi00 commented May 2, 2023

Leftovers:

  • Adding "hide all content tagged with nsfw" in settings, I am not sure how would we filter this in explore
  • NSFW Cards - again not sure where to get nsfw values for cards since it isnt done yet for nftentities

@yangwao
Copy link
Member

yangwao commented May 2, 2023

@kodadot/qa-guild

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use lewd instead of nsfw in code

components/gallery/GalleryItem.vue Outdated Show resolved Hide resolved
libs/ui/src/components/MediaItem/MediaItem.vue Outdated Show resolved Hide resolved
@degenofdotsama
Copy link

so this doesn't blur the home page preview but only if you click on an NFT?

it works fine when clicking on a NSFW NFT but does nothing
Screenshot 2023-05-02 at 07 57 48

Screenshot 2023-05-02 at 07 57 18

@reviewpad
Copy link
Contributor

reviewpad bot commented May 2, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@prachi00
Copy link
Member Author

prachi00 commented May 2, 2023

so this doesn't blur the home page preview but only if you click on an NFT?

it works fine when clicking on a NSFW NFT but does nothing Screenshot 2023-05-02 at 07 57 48

Screenshot 2023-05-02 at 07 57 18

yeah for explore we need kodadot/rubick#173 and kodadot/loligo#22 to clear first

@prachi00 prachi00 requested review from vikiival and floyd-li May 3, 2023 04:53
libs/ui/src/components/MediaItem/MediaItem.vue Outdated Show resolved Hide resolved
pages/transfer.vue Outdated Show resolved Hide resolved
@prachi00 prachi00 requested a review from floyd-li May 3, 2023 05:28
@prachi00 prachi00 requested a review from vikiival May 3, 2023 16:51
Co-authored-by: Jarsen <31397967+Jarsen136@users.noreply.github.com>
@prachi00 prachi00 requested a review from Jarsen136 May 4, 2023 05:48
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@codeclimate
Copy link

codeclimate bot commented May 7, 2023

Code Climate has analyzed commit e878ca1 and detected 0 issues on this pull request.

View more on Code Climate.

@prachi00
Copy link
Member Author

prachi00 commented May 7, 2023

can we merge this?

@vikiival vikiival merged commit 154f6bf into main May 10, 2023
19 checks passed
@vikiival vikiival deleted the feat-nsfw branch May 10, 2023 12:44
@vikiival
Copy link
Member

pay 45 usd

@yangwao
Copy link
Member

yangwao commented May 10, 2023

😍 Perfect, I’ve sent the payout
💵 $45 @ 26.01 USD/KSM ~ 1.73 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x93d2e570a32ec205a3f73ed52ea55bc68c3af4c89ccd6f3f1234b9d770105d39

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants