#5852 Buefy icon to neo icon #5858

prachi00 · 2023-05-04T04:31:23Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Context

Closes #<issue_number>
Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality

Optional

I've tested it at </ksm/collection>
I've tested PR on mobile
I've written unit tests 🧪
I've found edge cases

Had issue bounty label?

Fill up your KSM address:
Payout

Community participation

Are you at KodaDot Discord?

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

`🤖 Generated by Copilot at 191f617`

This pull request adds, replaces, or updates various icons and tooltips in the UI components of the NFT gallery, using NeoIcon and Font Awesome libraries. It also adds or improves some features related to NFT minting, filtering, liking, and displaying. It affects the following files: components/common/FrequentlyAsked.vue, components/common/IdentityForm.vue, components/explore/FilterMenuButton.vue, components/identity/module/IdentityPopoverHeader.vue, components/identity/module/IdentitySocial.vue, components/landing/CuratedList.vue, components/landing/EsCarbonless.vue, components/landing/EsSustainability.vue, components/Navbar.vue, components/navbar/MobileExpandableSection.vue, components/rmrk/Create/DropUpload.vue, components/rmrk/Create/SimpleMint.vue, components/rmrk/Gallery/EmotionList.vue, components/rmrk/Gallery/GalleryCard.vue, components/rmrk/Gallery/History.vue, components/rmrk/Gallery/Holder/Holder.vue, components/rmrk/Gallery/Layout.vue, components/TheFooter.vue, components/common/LoadPreviousPage.vue, and components/rmrk/Gallery/Item/Facts.vue.

`🤖 Generated by Copilot at 191f617`

We're adding icons to the pages, NeoIcon is the name
We're using Font Awesome brands, to give them all some fame
We're refactoring the logic, to make the code more clean
We're heaving on the count of three, to make the website gleam

netlify · 2023-05-04T04:31:39Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`6b95320`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/645da9a35935390008d7d986
😎 Deploy Preview	https://deploy-preview-5858--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

reviewpad · 2023-05-04T04:32:16Z

AI-Generated Summary: This pull request updates the icon component throughout multiple files, replacing the <b-icon> component with the <NeoIcon> component from the @kodadot1/brick package. The necessary import statements and component registrations have been updated accordingly. The new icons retain the same functionality as the original implementation with updated styling and consistency across the project.

reviewpad · 2023-05-04T04:32:20Z

Reviewpad Report

⚠️ Warnings

Please link an issue to the pull request

prachi00 · 2023-05-04T04:40:01Z

Also, does anyone know why deepsource says neoIcon is defined but isnt used, when it IS being used

roiLeo

Some smoll stuff:

self closing tag
size prop
default small? does it make big change on UI?

otherwise code lgtm ✅

components/identity/module/IdentityPopoverHeader.vue

components/rmrk/Gallery/History.vue

components/rmrk/Gallery/Holder/Holder.vue

components/rmrk/Gallery/PriceChart.vue

components/series/SeriesTable.vue

components/shared/Sharing.vue

pages/teleport.vue

pages/transfer.vue

roiLeo

Some smoll stuff:

self closing tag
size prop
default small? does it make big change on UI?

otherwise code lgtm ✅

vikiival · 2023-05-04T12:38:29Z

Agree with @roiLeo

roiLeo · 2023-05-04T13:27:07Z

Agree with @roiLeo

Co-authored-by: roiLeo <medina.leo42@gmail.com>

components/rmrk/Gallery/EmotionList.vue

Co-authored-by: Viki Val <viktorko99@gmail.com>

prachi00 · 2023-05-07T22:09:18Z

can we merge this?

components/common/IdentityForm.vue

vikiival

Smol

vikiival · 2023-05-08T11:59:20Z

Spawing @exezbcz

exezbcz · 2023-05-08T12:02:39Z

hi! some icons are broken, can you please fix them:

footer

- the hover bg color is oki but the icon should be k-black in case of dark mode, also it should not change when you hover over the icon itself. - canary: -

deploy (hover over button):

deploy hover over icon:

Waiting for authorization

canary:
deploy:

Co-authored-by: Viki Val <viktorko99@gmail.com>

prachi00 · 2023-05-08T19:38:07Z

hi! some icons are broken, can you please fix them:

footer

the hover bg color is oki but the icon should be k-black in case of dark mode, also it should not change when you hover over the icon itself. - canary: -

deploy (hover over button):

deploy hover over icon:

Waiting for authorization

canary: deploy:

done @exezbcz

vikiival · 2023-05-11T19:23:05Z

@prachi00 please resolve conflicts

prachi00 · 2023-05-12T02:51:37Z

@prachi00 please resolve conflicts

done

codeclimate · 2023-05-12T02:51:39Z

Code Climate has analyzed commit 6b95320 and detected 0 issues on this pull request.

View more on Code Climate.

vikiival · 2023-05-12T11:40:34Z

pay 50 usd

yangwao · 2023-05-12T11:40:47Z

😍 Perfect, I’ve sent the payout
💵 $50 @ 24.69 USD/KSM ~ 2.025 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xcd09488e10a7d0e4af36cb690fe97c3f5736bc9ec5409e3f77a31698c463a760

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

buefy icon to neo icon

191f617

prachi00 requested a review from a team as a code owner May 4, 2023 04:31

prachi00 requested review from roiLeo and vikiival and removed request for a team May 4, 2023 04:31

remove useless import

fd2c770

reviewpad bot added medium Pull request is medium waiting-for-review labels May 4, 2023

prachi00 mentioned this pull request May 4, 2023

Goodbye Buefy #5852

Closed

37 tasks

roiLeo reviewed May 4, 2023

View reviewed changes

prachi00 and others added 13 commits May 4, 2023 16:04

Update components/rmrk/Gallery/History.vue

a89b1fb

Co-authored-by: roiLeo <medina.leo42@gmail.com>

Update components/rmrk/Gallery/Holder/Holder.vue

76cd57b

Co-authored-by: roiLeo <medina.leo42@gmail.com>

Update components/rmrk/Gallery/PriceChart.vue

a234f20

Co-authored-by: roiLeo <medina.leo42@gmail.com>

Update components/shared/Sharing.vue

9a8f1e9

Co-authored-by: roiLeo <medina.leo42@gmail.com>

Update pages/teleport.vue

cbb3eb0

Co-authored-by: roiLeo <medina.leo42@gmail.com>

Update pages/transfer.vue

3db39b8

Co-authored-by: roiLeo <medina.leo42@gmail.com>

Update pages/transfer.vue

378dc64

Co-authored-by: roiLeo <medina.leo42@gmail.com>

Update pages/teleport.vue

8a20890

Co-authored-by: roiLeo <medina.leo42@gmail.com>

Update components/series/SeriesTable.vue

f14330d

Co-authored-by: roiLeo <medina.leo42@gmail.com>

Update components/series/SeriesTable.vue

31fe265

Co-authored-by: roiLeo <medina.leo42@gmail.com>

changes

e487219

Update components/explore/FilterMenuButton.vue

d56e677

Co-authored-by: roiLeo <medina.leo42@gmail.com>

Update components/rmrk/Create/DropUpload.vue

26b3b95

Co-authored-by: roiLeo <medina.leo42@gmail.com>

vikiival reviewed May 5, 2023

View reviewed changes

components/rmrk/Gallery/EmotionList.vue Outdated Show resolved Hide resolved

prachi00 and others added 4 commits May 5, 2023 09:21

Update components/common/IdentityForm.vue

a2c86a2

Co-authored-by: Viki Val <viktorko99@gmail.com>

Update components/rmrk/Gallery/EmotionList.vue

5fa539f

Co-authored-by: Viki Val <viktorko99@gmail.com>

Update components/rmrk/Create/SimpleMint.vue

3a87f22

Co-authored-by: Viki Val <viktorko99@gmail.com>

Merge branch 'main' into feat-neo-icons

b3da03e

prachi00 requested a review from vikiival May 5, 2023 16:22

Merge branch 'main' into feat-neo-icons

d7c1711

vikiival reviewed May 8, 2023

View reviewed changes

components/common/IdentityForm.vue Outdated Show resolved Hide resolved

vikiival reviewed May 8, 2023

View reviewed changes

prachi00 and others added 5 commits May 8, 2023 09:31

Merge branch 'main' into feat-neo-icons

f5aebfe

footer icon fix

91dc106

Update components/common/IdentityForm.vue

d53ab4c

Co-authored-by: Viki Val <viktorko99@gmail.com>

auth icon fix

89857a9

auth icon fix

2049d33

Merge branch 'main' into feat-neo-icons

a63e917

vikiival approved these changes May 9, 2023

View reviewed changes

conflicts

870a028

conflicts

6b95320

vikiival merged commit caf99b9 into main May 12, 2023
18 of 19 checks passed

vikiival deleted the feat-neo-icons branch May 12, 2023 11:40

yangwao added the paid pull-request has been paid label May 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#5852 Buefy icon to neo icon #5858

#5852 Buefy icon to neo icon #5858

prachi00 commented May 4, 2023 •

edited by ghost

netlify bot commented May 4, 2023 •

edited

reviewpad bot commented May 4, 2023

reviewpad bot commented May 4, 2023

prachi00 commented May 4, 2023

roiLeo left a comment

roiLeo left a comment

vikiival commented May 4, 2023

roiLeo commented May 4, 2023

prachi00 commented May 7, 2023

vikiival left a comment

vikiival commented May 8, 2023

exezbcz commented May 8, 2023

prachi00 commented May 8, 2023

footer

Waiting for authorization

vikiival commented May 11, 2023

prachi00 commented May 12, 2023

codeclimate bot commented May 12, 2023

vikiival commented May 12, 2023

yangwao commented May 12, 2023

#5852 Buefy icon to neo icon #5858

#5852 Buefy icon to neo icon #5858

Conversation

prachi00 commented May 4, 2023 • edited by ghost

PR Type

Context

Before submitting pull request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot 📸

Copilot Summary

🤖 Generated by Copilot at 191f617

🤖 Generated by Copilot at 191f617

netlify bot commented May 4, 2023 • edited

✅ Deploy Preview for koda-canary ready!

reviewpad bot commented May 4, 2023

reviewpad bot commented May 4, 2023

prachi00 commented May 4, 2023

roiLeo left a comment

Choose a reason for hiding this comment

roiLeo left a comment

Choose a reason for hiding this comment

vikiival commented May 4, 2023

roiLeo commented May 4, 2023

prachi00 commented May 7, 2023

vikiival left a comment

Choose a reason for hiding this comment

vikiival commented May 8, 2023

exezbcz commented May 8, 2023

footer

Waiting for authorization

prachi00 commented May 8, 2023

footer

Waiting for authorization

vikiival commented May 11, 2023

prachi00 commented May 12, 2023

codeclimate bot commented May 12, 2023

vikiival commented May 12, 2023

yangwao commented May 12, 2023

prachi00 commented May 4, 2023 •

edited by ghost

`🤖 Generated by Copilot at 191f617`

`🤖 Generated by Copilot at 191f617`

netlify bot commented May 4, 2023 •

edited