Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip improvements #5862

Merged
merged 4 commits into from
May 12, 2023
Merged

Tooltip improvements #5862

merged 4 commits into from
May 12, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented May 5, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • fix isssue where tooltip was not above content (works only if append-to-body:false)
  • font-size prop on NeoTooltip (works only if append-to-body:false)
  • add multiline option
  • refactor scss
  • make append-to-body prop false by default

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 932aa85

Refactored and enhanced the NeoTooltip component to use Oruga and added new props and style options. Updated the usage of the append-to-body prop in various components to improve tooltip visibility and avoid overlaps.

🤖 Generated by Copilot at 932aa85

Sing, O Muse, of the skillful coder who changed the NeoTooltip
And made it more flexible and elegant with Oruga's help
He removed the append-to-body prop from many a component
And added it where it was needed, with wisdom and intent

@daiagi daiagi requested a review from a team as a code owner May 5, 2023 03:05
@daiagi daiagi requested review from preschian and vikiival and removed request for a team May 5, 2023 03:05
@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0db9657
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645727584608290008adeb35
😎 Deploy Preview https://deploy-preview-5862--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 5, 2023

AI-Generated Summary: This pull request primarily focuses on tooltip improvements, including updates to the NeoTooltip component and changes in how tooltips are used in various components. The patch modifies 9 files with 36 insertions and 51 deletions.

Key changes:

  • A new multiline prop and computedFontSize are added to the NeoTooltip component.
  • The appendToBody prop is updated in several components, reflecting different tooltip behaviors.
  • The NeoTooltip SCSS file is cleaned up to remove unused variables and styles.
  • Some unused imports are removed from the NeoTooltip component.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 5, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 5, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@daiagi daiagi mentioned this pull request May 5, 2023
16 tasks
@daiagi
Copy link
Contributor Author

daiagi commented May 5, 2023

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks oki, smoll stuff

@daiagi daiagi requested a review from vikiival May 6, 2023 04:51
@vikiival
Copy link
Member

vikiival commented May 6, 2023

Hello, can you please resolve conflicts?

@codeclimate
Copy link

codeclimate bot commented May 7, 2023

Code Climate has analyzed commit 0db9657 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 5b28cb5 into main May 12, 2023
19 checks passed
@vikiival vikiival deleted the fix-NeoTooltip branch May 12, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants