Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade polkadot packages #5864

Merged
merged 5 commits into from
May 11, 2023
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented May 5, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at ec7e454

This pull request improves the node modules compatibility, the browser targeting, and the Polkadot dependencies of the project. It modifies the nuxt.config.js, .browserslistrc, and package.json files accordingly.

🤖 Generated by Copilot at ec7e454

We are the NFT warriors, we defy the old and stale
We update our dependencies, we optimize our code
We use the Polkadot API, we display our identities
We tweak our webpack config, we rule the smoldot-light

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1732975
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645cde24dafbc90007e4e792
😎 Deploy Preview https://deploy-preview-5864--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 5, 2023

AI-Generated Summary: This pull request includes changes to nuxt.config.js, package.json, and .browserslistrc. In nuxt.config.js, the changes affect babel-loader configuration and update the test for .mjs files. In package.json, several dependencies have been updated, and new dependencies are added, such as @polkadot/api, @polkadot/api-base, and @polkadot/apps-config. The .browserslistrc file has been updated with new criteria for targeted browsers, potentially broadening the range of supported browsers while excluding certain older or less relevant ones.

@reviewpad reviewpad bot added the large Pull request is large label May 5, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 5, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@socket-security
Copy link

socket-security bot commented May 5, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@polkadot/apps-config@0.129.1 None +15 polkadotjs
⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@polkadot/ui-keyring@3.3.1 3.1.4...3.3.1 None +4/-14 polkadotjs

🚮 Removed packages: @paraspell/sdk@0.0.25, @polkadot/extension-dapp@0.45.5, @polkadot/extension-inject@0.45.5

@preschian
Copy link
Member Author

the issue still exists, I will check in the other packages. changes in this PR:

  • fix loader for a newer @polkadot/* packages
  • unify .mjs loader
  • upgrade @paraspell/sdk to a newer version. how to test this btw?

Screenshot 2023-05-05 154604

@preschian preschian marked this pull request as ready for review May 5, 2023 08:49
@preschian preschian requested a review from a team as a code owner May 5, 2023 08:49
@preschian preschian requested review from roiLeo and daiagi and removed request for a team May 5, 2023 08:49
@roiLeo
Copy link
Contributor

roiLeo commented May 5, 2023

* upgrade `@paraspell/sdk` to a newer version. how to test this btw?

This is used in /teleport-bridge page

@preschian
Copy link
Member Author

* upgrade `@paraspell/sdk` to a newer version. how to test this btw?

This is used in /teleport-bridge page

seems stuck on the rpc is pending on my end. I check it on canary

@vikiival
Copy link
Member

vikiival commented May 5, 2023

the issue still exists, I will check in the other packages. changes in this PR:

fix loader for a newer @polkadot/* packages

please also update packages in sub-api (kodadot/packages)

unify .mjs loader

Won't this cause slower build times?

upgrade @paraspell/sdk to a newer version. how to test this btw?

@vikiival
Copy link
Member

vikiival commented May 5, 2023

So @preschian paraspell was updated

@vikiival
Copy link
Member

vikiival commented May 8, 2023

Pushed new @paraspell sdk

also opened:

@preschian
Copy link
Member Author

please also update packages in sub-api (kodadot/packages)

related PR kodadot/packages#137

Won't this cause slower build times?

seems not. but, let me know if you found out that it makes the build slower

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks oki, we might have to check if transpile is still needed

Comment on lines +82 to +83
"@polkadot/api-base": "^10.6.1",
"@polkadot/apps-config": "^0.129.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new deps? are they needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, based on their instruction https://github.com/paraspell/xcm-sdk#install-deps-via-npmyarnpnpm

if I removed those packages will error

ERROR in ./node_modules/.pnpm/@paraspell+sdk@1.1.4/node_modules/@paraspell/sdk/dist/index.mjs
Module not found: Error: Can't resolve '@polkadot/apps-config/endpoints' in

@vikiival
Copy link
Member

Fresh from KodaDot bakery:
cc @preschian

  • @kodadot1/minimark@0.1.9
  • @kodadot1/sub-api@0.1.2

@vikiival
Copy link
Member

vuex-options were already released to main because of the breaking change :)

@codeclimate
Copy link

codeclimate bot commented May 11, 2023

Code Climate has analyzed commit 1732975 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit b4b736d into main May 11, 2023
19 checks passed
@vikiival vikiival deleted the chore/upgrade-polkadot-packages branch May 11, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants