Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chart dropdown menu all white buttons #5875

Merged
merged 3 commits into from
May 10, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 7, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

Copilot Summary

🤖 Generated by Copilot at 73ccf5e

Simplify active dropdown item styling in NeoDropdown.scss. Use inherited background color instead of inverse text color for better flexibility and consistency.

🤖 Generated by Copilot at 73ccf5e

Sing, O Muse, of the skillful coder who refined
the styling of the active dropdown item, and thus
removed the inverse text color, a harsh contrast,
and used the inherited background, a subtle grace.

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 7, 2023 12:54
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team May 7, 2023 12:54
@kodabot
Copy link
Collaborator

kodabot commented May 7, 2023

WARNING @Jarsen136 PR for issue #5865 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5865

@netlify
Copy link

netlify bot commented May 7, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9715d4b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645a5c4b8aadd3000809641c
😎 Deploy Preview https://deploy-preview-5875--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 7, 2023

AI-Generated Summary: This pull request addresses an issue with the Chart dropdown menu having all white buttons. The patch modifies the NeoDropdown.scss file by changing the active button CSS classes and adding an additional state for the --active class to inherit the background property. This results in a more visually pleasing and functional dropdown menu.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 7, 2023
@exezbcz
Copy link
Member

exezbcz commented May 7, 2023

it sometimes switch the text on hover to k-white, should be k-black
image

@Jarsen136
Copy link
Contributor Author

it sometimes switch the text on hover to k-white, should be k-black image

✅ Fixed

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug in this file I guess https://github.com/kodadot/nft-gallery/blob/main/components/chart/PriceChart.vue#LL19C47-L19C47

fixed with this change

@click.native="setTimeRange({ value: range.value, label: range.label })"

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 9, 2023
@codeclimate
Copy link

codeclimate bot commented May 9, 2023

Code Climate has analyzed commit 9715d4b and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

bug in this file I guess https://github.com/kodadot/nft-gallery/blob/main/components/chart/PriceChart.vue#LL19C47-L19C47

fixed with this change

@click.native="setTimeRange({ value: range.value, label: range.label })"

Thanks. It also fixes the bug.

@prury prury requested review from prury and removed request for prury May 9, 2023 14:47
@yangwao
Copy link
Member

yangwao commented May 10, 2023

pay 20 usd
perfect

1 similar comment
@yangwao
Copy link
Member

yangwao commented May 10, 2023

pay 20 usd
perfect

@yangwao
Copy link
Member

yangwao commented May 10, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 26 USD/KSM ~ 0.769 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x82454ff16ab97f63cd0f5be45700565576e749da1e8279f7fb2bf4666fafee16

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 10, 2023
@yangwao yangwao merged commit 6e652f9 into kodadot:main May 10, 2023
19 checks passed
@yangwao
Copy link
Member

yangwao commented May 10, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 26 USD/KSM ~ 0.769 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x36e180b05f7b91e4a9c6673ba31dfe08341dd9dce69be7269edd2f6f35df4c5e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao
Copy link
Member

yangwao commented May 10, 2023

whatever

@yangwao
Copy link
Member

yangwao commented May 10, 2023

gh have fun

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart dropdown menu all white buttons
8 participants