Massmint: Make It Mint #5882
Massmint: Make It Mint #5882
Conversation
…ssmint/make-it-mint
…ssmint/make-it-mint
daiagi
requested review from
preschian and
Jarsen136
and removed request for
a team
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
…ssmint/make-it-mint
…ssmint/make-it-mint
| @@ -38,6 +37,26 @@ export const validFormats = [ | |||
| 'mp3', | |||
| 'json', | |||
| ] | |||
| export const mimeTypes: { [key: string]: string } = { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| } | ||
| } | ||
|
|
||
| export const getListForSellItems = ( |
There was a problem hiding this comment.
Function getListForSellItems has 32 lines of code (exceeds 25 allowed). Consider refactoring.
| @@ -83,3 +96,60 @@ export const useCollectionForMint = () => { | |||
| collectionsEntites, | |||
| } | |||
| } | |||
|
|
|||
| export const useMassMint = ( | |||
There was a problem hiding this comment.
Function useMassMint has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
| @@ -83,3 +96,60 @@ export const useCollectionForMint = () => { | |||
| collectionsEntites, | |||
| } | |||
| } | |||
|
|
|||
| export const useMassMint = ( | |||
There was a problem hiding this comment.
Function useMassMint has 44 lines of code (exceeds 25 allowed). Consider refactoring.
| return collectionUpdated | ||
| } | ||
|
|
||
| export const listForSell = (mintedNFts: TokenToList[]) => { |
There was a problem hiding this comment.
Function listForSell has 28 lines of code (exceeds 25 allowed). Consider refactoring.
yes indeed very large PR, too large |
i was able to transport some ksm using the Talisman webapp, too bad DOT teleport isn't working there @daiagi if i don't have a Statemine collection, will i be able to create one using this deployed version(using the massmint menu)? |
|
@prury that's an issue as statemine create page is not implements yet |
| } | ||
| } | ||
|
|
||
| export const kusamaMintAndList = (tokens) => { |
There was a problem hiding this comment.
Function kusamaMintAndList has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Got it, its huge indeed, so, did some additional tests today and massminted NFTs on both RMRK2 and BSX, it went perfectly well, no console errors, some had price some others not, working fine on those two networks plus SNEK. BSX, without listing: RMRK2, listing(not cheap tho): |
prury
added
the
S-works-for-me-✅
|
Please solve some conflicting code. @daiagi |
…ssmint/make-it-mint
done |
|
Code Climate has analyzed commit d46e176 and detected 25 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
pay 100 usd |
@yangwao |
|
pay 150 usd |
|
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at cdabb9d
The pull request adds and refactors code for the mass mint feature, which allows the user to mint multiple NFTs from compressed media files. It introduces new components for the user interface, such as dropdowns, modals and a sidebar. It also updates the types and functions for the minting logic and the metadata construction. It modifies some existing components and files to support the new feature and improve the code quality.
🤖 Generated by Copilot at cdabb9d