Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5853 neo modal #5883

Merged
merged 3 commits into from
May 12, 2023
Merged

#5853 neo modal #5883

merged 3 commits into from
May 12, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented May 9, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 4b38697

Implemented a custom NeoModal component to improve modal design and performance. Refactored GalleryItemPreviewer.vue to use the new component.

🤖 Generated by Copilot at 4b38697

To improve the modal design and speed
They replaced b-modal with NeoModal indeed
They created a custom component
With TypeScript and Vue Class Component
And passed props to b-modal with ease

@prachi00 prachi00 requested a review from a team as a code owner May 9, 2023 03:18
@prachi00 prachi00 requested review from roiLeo and vikiival and removed request for a team May 9, 2023 03:18
@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit de7f6de
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645e28109e73a000089524ef
😎 Deploy Preview https://deploy-preview-5883--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prachi00 prachi00 mentioned this pull request May 9, 2023
37 tasks
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 9, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 9, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ wfm, this fix issue GalleryItemPreviewer doesn't work on beta

fix conflict and let it roll 🎢

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 11, 2023
@codeclimate
Copy link

codeclimate bot commented May 12, 2023

Code Climate has analyzed commit de7f6de and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

@prachi00 can I ask you next time to check the usage of the component before making API change?

Screenshot 2023-05-12 at 13 46 31

None of these components know props you added ^-^

Fixed in de7f6de

@vikiival vikiival merged commit 1fc5daa into main May 12, 2023
13 of 14 checks passed
@vikiival vikiival deleted the feat-neo-modal-move branch May 12, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants