Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➖ remove FAQ component #5885

Merged
merged 1 commit into from
May 10, 2023
Merged

➖ remove FAQ component #5885

merged 1 commit into from
May 10, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 9, 2023

Removed /rmrk/faq page

PR Type

  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Copilot Summary

🤖 Generated by Copilot at ba3ef0a

No summary available (Limit exceeded: required to process 81205 tokens, but only 50000 are allowed per call)

copilot:poem

@roiLeo roiLeo requested a review from a team as a code owner May 9, 2023 10:52
@roiLeo roiLeo requested review from preschian and vikiival and removed request for a team May 9, 2023 10:52
@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ba3ef0a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645a25e89b98f60008ad7e9b
😎 Deploy Preview https://deploy-preview-5885--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels May 9, 2023
@codeclimate
Copy link

codeclimate bot commented May 9, 2023

Code Climate has analyzed commit ba3ef0a and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

vikiival commented May 9, 2023

I assigned @JustLuuuu to check if we can reuse some parts in hello

@vikiival vikiival added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 9, 2023
@JustLuuuu
Copy link
Member

I assigned @JustLuuuu to check if we can reuse some parts in hello

Reused some parts.

@yangwao
Copy link
Member

yangwao commented May 10, 2023

FAQ is seems under

Seems we will do revisit of footer links to hello.

once removed 'knowledge-base' middlefix, we can revisit footer.

Great for now, hope lower bundle a lil bit.

@yangwao yangwao merged commit 78e1b08 into kodadot:main May 10, 2023
20 checks passed
@roiLeo roiLeo deleted the chore/remove/faq branch May 10, 2023 12:33
@yangwao yangwao mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redesign: FAQ section
4 participants