Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5886 remove whitelist rmrk2 #5890

Merged
merged 1 commit into from
May 9, 2023
Merged

#5886 remove whitelist rmrk2 #5890

merged 1 commit into from
May 9, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented May 9, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at ae4d4cc

Simplified the wallet connection component and removed obsolete code. Moved the rmrk2 account redirection logic to a middleware function in middleware/rmrk2.ts. Deleted the unused whitelist.ts file.

🤖 Generated by Copilot at ae4d4cc

Oh we're the coders of the high seas
We trim the imports and refactor with ease
On the count of three we pull the rmrk2 line
And send the logic to the middleware fine

@prachi00 prachi00 requested a review from a team as a code owner May 9, 2023 16:28
@prachi00 prachi00 requested review from roiLeo and daiagi and removed request for a team May 9, 2023 16:28
@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ae4d4cc
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645a74b276bcc8000899b78b
😎 Deploy Preview https://deploy-preview-5890--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 9, 2023

AI-Generated Summary: This pull request removes the whitelist for redirecting to Rmrk2 hostnames. It includes the deletion of the whitelist.ts file and updates the ConnectWalletModal.vue file by removing the code that checks for the presence of a whitelisted address and performs the redirection. This results in the removal of 16 lines of code in total.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 9, 2023
@codeclimate
Copy link

codeclimate bot commented May 9, 2023

Code Climate has analyzed commit ae4d4cc and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 9, 2023
@yangwao
Copy link
Member

yangwao commented May 9, 2023

pay 20 usd

@yangwao yangwao merged commit 0adc312 into main May 9, 2023
20 checks passed
@yangwao yangwao deleted the feat-remove-whitelist branch May 9, 2023 18:39
@yangwao
Copy link
Member

yangwao commented May 9, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 25.69 USD/KSM ~ 0.779 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x4fb62d54da0cd8251777ab43d39e2be12de81e21f25557ce0a07a918cae14d8b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 9, 2023
@yangwao yangwao mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove rmrk2 allowlist
3 participants