Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5889 hiding stats #5894

Merged
merged 9 commits into from
May 12, 2023
Merged

#5889 hiding stats #5894

merged 9 commits into from
May 12, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented May 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
Screen Shot 2023-05-09 at 6 22 33 PM

Copilot Summary

🤖 Generated by Copilot at eb8cd9a

Removed StatsDropdown from navbar and cleaned up unused code. This change makes the navbar faster and less cluttered.

🤖 Generated by Copilot at eb8cd9a

Sing, O Muse, of the swift and skillful coder
Who from the navbar StatsDropdown removed
To make the page more swift and less encumbered
And please the users with a smoother groove.

@prachi00 prachi00 requested a review from a team as a code owner May 10, 2023 01:23
@prachi00 prachi00 requested review from preschian and Jarsen136 and removed request for a team May 10, 2023 01:23
@kodabot
Copy link
Collaborator

kodabot commented May 10, 2023

SUCCESS @prachi00 PR for issue #5889 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c40454f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645dd364ffb67500080febaf
😎 Deploy Preview https://deploy-preview-5894--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 10, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 10, 2023

AI-Generated Summary: This pull request removes the StatsDropdown component from Navbar.vue and its associated import statement. This results in the stats dropdown no longer being displayed in the navigation bar.

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjust e2e test also please

cy.get('[data-cy="stats"]').should('be.visible')
. otherwise lgtm

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  2 failing

  1) landingRmrk
       loadLanding:
     AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-cy="spotlight"]`, but never found it.
      at Context.eval (webpack:///./cypress/support/commands.ts:34:5)

  2) landingBsx
       loadLanding:
     AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-cy="global-offers"]`, but never found it.
      at Context.eval (webpack:///./cypress/support/commands.ts:56:5)

Comment code instead of remove it?

@prachi00 prachi00 requested review from roiLeo and preschian May 11, 2023 02:55
@preschian
Copy link
Member

@prachi00 almost, and fix deepscan

  2 failing

  1) landingRmrk
       loadLanding:
     AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-cy="series-insight"]`, but never found it.
      at Context.eval (webpack:///./cypress/support/commands.ts:34:5)

  2) landingBsx
       loadLanding:
     AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-cy="offers-stats"]`, but never found it.
      at Context.eval (webpack:///./cypress/support/commands.ts:53:5)

@prachi00
Copy link
Member Author

@prachi00 almost, and fix deepscan

  2 failing

  1) landingRmrk
       loadLanding:
     AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-cy="series-insight"]`, but never found it.
      at Context.eval (webpack:///./cypress/support/commands.ts:34:5)

  2) landingBsx
       loadLanding:
     AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-cy="offers-stats"]`, but never found it.
      at Context.eval (webpack:///./cypress/support/commands.ts:53:5)

fixed

@preschian
Copy link
Member

fixed

still error. could you please test in your local first and then commit 😅

@prachi00
Copy link
Member Author

prachi00 commented May 12, 2023

fixed

still error. could you please test in your local first and then commit 😅

yes would you mind confirming the correct e2e command with me, I run test:e2e this on my local but it never finds these errors it seems

EDIT: resolved now

@codeclimate
Copy link

codeclimate bot commented May 12, 2023

Code Climate has analyzed commit c40454f and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 12, 2023
@preschian
Copy link
Member

yes would you mind confirming the correct e2e command with me, I run test:e2e this on my local but it never finds these errors it seems

aahh i see, for me usually run test:e2e-gui and test specific test case

@vikiival vikiival merged commit 1d30368 into main May 12, 2023
15 checks passed
@vikiival vikiival deleted the feat-hiding-stats branch May 12, 2023 12:12
@vikiival
Copy link
Member

pay 10 usd

@yangwao
Copy link
Member

yangwao commented May 12, 2023

😍 Perfect, I’ve sent the payout
💵 $10 @ 24.69 USD/KSM ~ 0.405 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xbad30f2dd5da36dff8e527c6e21ade28d61567444d629d6de5f0b9b96e344d17

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Stats
6 participants