Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➖ remove b-progress component #5895

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 10, 2023

For now removing this component since it isn't used (and never shown)
If we will need a progress bar component, wait for design and use progress html tag instead

PR Type

  • Refactoring

Context

  • related with Goodbye Buefy #5852
  • migrate Metadata component to Vue3 composition api
  • remove auto import

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Screenshot 📸

Capture d’écran 2023-05-10 à 1 55 21 PM

Copilot Summary

🤖 Generated by Copilot at acf5f26

Refactor Metadata.vue component to use Vue 3 <script setup> syntax and useChain composable function. Simplify the handling of loading and error states and the display of chainProperties fields.

🤖 Generated by Copilot at acf5f26

<script setup> now
simplifies components - no
mixins or watchers

@roiLeo roiLeo requested a review from a team as a code owner May 10, 2023 12:03
@roiLeo roiLeo requested review from vikiival and daiagi and removed request for a team May 10, 2023 12:03
@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit acf5f26
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645b8804125d9b00084c3117
😎 Deploy Preview https://deploy-preview-5895--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 10, 2023

AI-Generated Summary: This pull request removes the b-progress component and its related code from the Metadata.vue file. In addition, it simplifies the value bindings of DisabledInput components by removing the unnecessary loading check.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 10, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 10, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented May 10, 2023

Code Climate has analyzed commit acf5f26 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo mentioned this pull request May 10, 2023
37 tasks
@vikiival vikiival merged commit dfd7bb5 into kodadot:main May 10, 2023
20 checks passed
@vikiival
Copy link
Member

pay 25 usd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants