Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Connect your wallet in create not working #5902

Merged
merged 2 commits into from
May 10, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at d3691ee

This pull request enhances the ConnectWalletButton component by adding a prop to control the connect modal and removing unnecessary code. This prevents nested modals from appearing when the button is used in other modals, such as in the CreateCollectionModal.

🤖 Generated by Copilot at d3691ee

No more nested modals of doom
We disable the toggle with a prop
ConnectWalletButton is improved
We remove the code that makes us flop

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 10, 2023 14:37
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team May 10, 2023 14:37
@kodabot
Copy link
Collaborator

kodabot commented May 10, 2023

SUCCESS @Jarsen136 PR for issue #5899 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d3691ee
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645bac3c275a970008110a49
😎 Deploy Preview https://deploy-preview-5902--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented May 10, 2023

Code Climate has analyzed commit d3691ee and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 10, 2023
@yangwao
Copy link
Member

yangwao commented May 10, 2023

pay 20 usd
fast tracking

@yangwao yangwao merged commit 5b29d7f into kodadot:main May 10, 2023
20 checks passed
@yangwao
Copy link
Member

yangwao commented May 10, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 25.89 USD/KSM ~ 0.772 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x44de510391c9be0e4bdafd2430de3da86c71fbdd0f0f220ada970fd3c79207ed

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect your wallet in create not working
3 participants