Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect rmrk2 prefix to ksm #5918

Merged
merged 2 commits into from
May 12, 2023
Merged

fix: redirect rmrk2 prefix to ksm #5918

merged 2 commits into from
May 12, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented May 11, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at c907ea7

Improved middleware for network switching and readability. Added feature flag to redirect rmrk2 to ksm routes in middleware/redirects.ts.

🤖 Generated by Copilot at c907ea7

rmrk2 or ksm?
Middleware can switch them
A flag cuts the flow

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 71774bf
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645cd76e7896670008be2861
😎 Deploy Preview https://deploy-preview-5918--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 11, 2023

AI-Generated Summary: This pull request adds a fix for redirecting the rmrk2 prefix to ksm in the middleware/redirects.ts file. The patch introduces 5 new lines of code that check if the current route path contains '/rmrk2/' and, if found, replaces it with '/ksm/' before redirecting.

@reviewpad reviewpad bot added the small Pull request is small label May 11, 2023
@preschian preschian marked this pull request as ready for review May 11, 2023 08:59
@preschian preschian requested a review from a team as a code owner May 11, 2023 08:59
@preschian preschian requested review from roiLeo and Jarsen136 and removed request for a team May 11, 2023 08:59
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ wfm

middleware/redirects.ts Outdated Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented May 11, 2023

question, are there rmrk2 outside somewhere wild?

@codeclimate
Copy link

codeclimate bot commented May 11, 2023

Code Climate has analyzed commit 71774bf and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@vikiival
Copy link
Member

question, are there rmrk2 outside somewhere wild?

No they shouldn't be.

Still wondering how did you get that link.

@preschian
Copy link
Member Author

question, are there rmrk2 outside somewhere wild?

No they shouldn't be.

Still wondering how did you get that link.

found one https://twitter.com/Abdulra49391530/status/1646776000703782914?s=20

@yangwao
Copy link
Member

yangwao commented May 12, 2023

ok u win

pay 20 usd

Still wondering how did you get that link.

i open links in my quantum state machine

@yangwao yangwao merged commit 7a14f72 into main May 12, 2023
18 of 19 checks passed
@yangwao yangwao deleted the fix/redirect-rmrk2-to-ksm branch May 12, 2023 19:46
@yangwao
Copy link
Member

yangwao commented May 12, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 24.48 USD/KSM ~ 0.817 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x1d119e697d794cbb35818a584aa73a4843f0c88bab8784efdab13865b9d9ac29

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 12, 2023
This was referenced May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I open rmrk2 item directly with link doesn't load
5 participants