Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 name could be null #5924

Merged
merged 1 commit into from
May 11, 2023
Merged

🐛 name could be null #5924

merged 1 commit into from
May 11, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented May 11, 2023

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

Screenshot 2023-05-11 at 16 30 44

Copilot Summary

🤖 Generated by Copilot at 765dca1

Fixed a bug that caused errors when sorting collections by popularity. Used optional chaining on a.meta.name in usePopularCollections.ts.

🤖 Generated by Copilot at 765dca1

Sorting collections
a.meta.name may be nil
Use optional chain

@vikiival vikiival requested a review from a team as a code owner May 11, 2023 14:33
@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team May 11, 2023 14:33
@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 765dca1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645cfc9f8ae3e40008a8efd8
😎 Deploy Preview https://deploy-preview-5924--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 11, 2023

AI-Generated Summary: This pull request addresses a bug where the name property could be null. A change has been made in the usePopularCollections.ts file to handle this case by adding an optional chaining operator before the localeCompare method. This ensures that the sorting function does not throw an error when the name is null.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 11, 2023
@codeclimate
Copy link

codeclimate bot commented May 11, 2023

Code Climate has analyzed commit 765dca1 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 11, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 11, 2023
@vikiival vikiival merged commit b87ab6c into main May 11, 2023
20 checks passed
@vikiival vikiival deleted the fix/unknown-name branch May 11, 2023 15:24
This was referenced May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants