Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add NeoDatepicker #5946

Merged
merged 3 commits into from
May 13, 2023
Merged

refactor: add NeoDatepicker #5946

merged 3 commits into from
May 13, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented May 13, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Copilot Summary

🤖 Generated by Copilot at 7373ffa

This pull request replaces the BasicDatePicker component with the NeoDatepicker component, which is a custom wrapper around the ODatepicker component from the Oruga UI library. The NeoDatepicker component is more consistent with the kodadot/nft-gallery design system and has a storybook component for documentation and testing.

🤖 Generated by Copilot at 7373ffa

NeoDatepicker
extends ODatepicker too
with custom styles

@reviewpad
Copy link
Contributor

reviewpad bot commented May 13, 2023

AI-Generated Summary: This pull request refactors the NeoDatepicker component by removing the old BasicDatePicker.vue and creating a new implementation in NeoDatepicker.vue. It also adds a story for the NeoDatepicker in NeoDatepicker.story.vue. In total, 35 lines have been added, and 26 lines have been deleted from the project.

@reviewpad reviewpad bot added the small Pull request is small label May 13, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 13, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@netlify
Copy link

netlify bot commented May 13, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a2b95ce
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645fa270097c8a0008d4c8da
😎 Deploy Preview https://deploy-preview-5946--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review May 13, 2023 11:55
@preschian preschian requested a review from a team as a code owner May 13, 2023 11:55
@preschian preschian requested review from vikiival and daiagi and removed request for a team May 13, 2023 11:55
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✔️

@roiLeo roiLeo mentioned this pull request May 13, 2023
37 tasks
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol we didn't even use BasicDatePicker component

@codeclimate
Copy link

codeclimate bot commented May 13, 2023

Code Climate has analyzed commit a2b95ce and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit 3852afb into main May 13, 2023
12 of 14 checks passed
@roiLeo roiLeo deleted the refactor/neo-datepicker branch May 13, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants