🔧 invalid props

[daiagi]

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes Neo Modal invalid props #5947
• Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality

Optional

• I've tested it at </ksm/collection>
• I've tested PR on mobile
• I've written unit tests 🧪
• I've found edge cases

Had issue bounty label?

• Fill up your KSM address: Payout

Community participation

• Are you at KodaDot Discord?

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at b6f43f6

Refactored the NeoModal component to remove unnecessary code and improve readability. Used the class prop to allow custom styles for different modal types.

🤖 Generated by Copilot at b6f43f6

Oh we're the crew of the NeoModal, we like to keep things neat
We don't need no redundant props or data to repeat
We heave away and simplify the template and the script
We only use the class prop to give our modal some zip

[kodabot]

SUCCESS @daiagi PR for issue #5947 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	f307609
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/645f9a5e1142220008e612b7
😎 Deploy Preview	https://deploy-preview-5948--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[reviewpad]

AI-Generated Summary: This pull request removes the 'contentClass' and 'rootClass' props from the NeoModal component in 'libs/ui/src/components/NeoModal/NeoModal.vue', as well as their default values in the 'props' definition.

[roiLeo]

Hmm.. I think it can be used as class prop (see oruga Modal Doc)

[daiagi]

It crashes the app on local host and prevent the modal from showing on canary

[roiLeo]

It crashes the app on local host and prevent the modal from showing on canary

props type are incorrect, here the fix

const props = withDefaults(
  defineProps<{
    value: boolean
    destroyOnHide?: boolean
    canCancel?: boolean
    fullScreen?: boolean
    contentClass?: string
    rootClass?: string
  }>(),
  {
    destroyOnHide: true,
    canCancel: true,
    fullScreen: false,
    contentClass: '',
    rootClass: '',
  }
)

[codeclimate]

Code Climate has analyzed commit f307609 and detected 0 issues on this pull request.

View more on Code Climate.

[roiLeo]

✅ code lgtm