Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to make offer due to balance issue #5953

Merged
merged 4 commits into from
May 15, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 13, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image

Copilot Summary

🤖 Generated by Copilot at dc1efde

Improved offer functionality and code quality in GalleryItemOffer.vue. Fixed a balance update bug.

🤖 Generated by Copilot at dc1efde

Some variables were not in use
So they got the axe and no excuse
To fetch the BSX balance
We imported a function with valence
And fixed a bug that caused some abuse

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 13, 2023 14:32
@Jarsen136 Jarsen136 requested review from vikiival and daiagi and removed request for a team May 13, 2023 14:32
@kodabot
Copy link
Collaborator

kodabot commented May 13, 2023

SUCCESS @Jarsen136 PR for issue #5938 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 13, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a5ee83f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64628b36206b350008193bb6
😎 Deploy Preview https://deploy-preview-5953--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 13, 2023

AI-Generated Summary: This pull request addresses a balance issue that prevented users from making offers. The changes include updating the GalleryItemOffer.vue file by refactoring the balance computation, using the getAsssetBalance() function from the API, and fetching the balance on component mount. This ensures that the user's balance is accurately displayed and allows them to make offers successfully.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 13, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please could you use pinia storage to fetch & get balance so we can share the value between components

@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 13, 2023
@Jarsen136 Jarsen136 marked this pull request as draft May 14, 2023 16:24
@Jarsen136 Jarsen136 marked this pull request as ready for review May 15, 2023 06:11
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: Unable to retrieve keypair '...' Warning poping on snek, I don't think it's related to this PR

@Jarsen136
Copy link
Contributor Author

Error: Unable to retrieve keypair '...' Warning poping on snek, I don't think it's related to this PR

It should be fixed now, as I merged the main branch into this one.

@roiLeo
Copy link
Contributor

roiLeo commented May 15, 2023

It should be fixed now, as I merged the main branch into this one.

Still not working for me

@Jarsen136 Jarsen136 requested review from a team and degenofdotsama and removed request for a team May 15, 2023 16:27
@Jarsen136
Copy link
Contributor Author

Error: Unable to retrieve keypair '...' Warning poping on snek, I don't think it's related to this PR
Still not working for me

I have tested it on snek and it work on my side. I guess you are facing a cache issue.
image

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked after clearing local storage

@roiLeo roiLeo mentioned this pull request May 15, 2023
8 tasks
@Jarsen136 Jarsen136 removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 15, 2023
@codeclimate
Copy link

codeclimate bot commented May 15, 2023

Code Climate has analyzed commit a5ee83f and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

Works!

Screenshot 2023-05-15 at 21 55 33

@vikiival vikiival merged commit 8ecf476 into kodadot:main May 15, 2023
16 of 19 checks passed
@vikiival
Copy link
Member

pay 15 usd

@yangwao
Copy link
Member

yangwao commented May 15, 2023

😍 Perfect, I’ve sent the payout
💵 $15 @ 25.76 USD/KSM ~ 0.582 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x90199f364af2dd7d57c12514bcc4626b703791fc2d735469b8044e8858c51b1d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to make offer due to balance issue
5 participants