Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: identity and remove persist in wallet store #5958

Merged
merged 1 commit into from
May 14, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented May 14, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Screenshot 2023-05-14 153509

  • Fill up your KSM address: Payout

Copilot Summary

🤖 Generated by Copilot at f3aff54

This pull request improves the identity and wallet state management by fetching the identity data on component mount and disabling the local storage persistence of the wallet store. It affects the files useIdentity.ts and wallet.ts.

🤖 Generated by Copilot at f3aff54

useIdentity calls
whichIdentity on mount
identity shown

@kodabot
Copy link
Collaborator

kodabot commented May 14, 2023

WARNING @preschian PR for issue #5949 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5949

@kodabot
Copy link
Collaborator

kodabot commented May 14, 2023

WARNING @preschian PR for issue #5956 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5956

@netlify
Copy link

netlify bot commented May 14, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f3aff54
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64609e74ea12bc0008f7c7a3
😎 Deploy Preview https://deploy-preview-5958--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 14, 2023

AI-Generated Summary: This pull request introduces a small fix related to identity and removes the persist functionality in wallet store. Changes are made in two files - 'useIdentity.ts' and 'wallet.ts'. In 'useIdentity.ts', an onMounted function is added to call whichIdentity if address.value is available. In 'wallet.ts', the persist property is removed from the store definition.

@reviewpad reviewpad bot added the small Pull request is small label May 14, 2023
@codeclimate
Copy link

codeclimate bot commented May 14, 2023

Code Climate has analyzed commit f3aff54 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian mentioned this pull request May 14, 2023
1 task
@preschian preschian marked this pull request as ready for review May 14, 2023 08:59
@preschian preschian requested a review from a team as a code owner May 14, 2023 08:59
@preschian preschian requested review from roiLeo and vikiival and removed request for a team May 14, 2023 08:59
@preschian preschian requested review from yangwao and daiagi May 14, 2023 08:59
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@yangwao
Copy link
Member

yangwao commented May 14, 2023

perfecto 👌 thank you for quick delivery!

pay 30 usd

image

https://kusama.subscan.io/extrinsic/0x9d8c7a9c91a2cdf4ace499c6d3d388303e4f574fa8b3f12208f2e5bf0d0d772b

@yangwao yangwao merged commit b8210ce into main May 14, 2023
16 of 20 checks passed
@yangwao yangwao deleted the fix/identity-and-wallet-store branch May 14, 2023 10:44
@yangwao
Copy link
Member

yangwao commented May 14, 2023

pay 30 usd

updated issue for you :)

@yangwao
Copy link
Member

yangwao commented May 14, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 25.23 USD/KSM ~ 1.189 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0xf1821b1628ea505eceb8741640567b4a1c12bdfcf41e14a0b6634e9ab4a422a7

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to retrieve keypair on canary for transfer Unable To mint on localhost
4 participants