Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Full screen button missing #5965

Merged
merged 2 commits into from
May 16, 2023
Merged

fix: Full screen button missing #5965

merged 2 commits into from
May 16, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 14, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image

Copilot Summary

🤖 Generated by Copilot at c494fef

Added dynamic blurring of lewd media items based on user settings and metadata. Modified isLewdBlurredLayer in MediaItem.vue to use isLewd prop.

🤖 Generated by Copilot at c494fef

isLewd prop blurs
media item in the fall
leaves nothing to see

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 14, 2023 15:33
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team May 14, 2023 15:33
@kodabot
Copy link
Collaborator

kodabot commented May 14, 2023

SUCCESS @Jarsen136 PR for issue #5963 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 14, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c16e627
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64633b1f98dd6400086af020
😎 Deploy Preview https://deploy-preview-5965--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 14, 2023

AI-Generated Summary: This pull request contains a single change to fix a missing full screen button in the MediaItem component. It modifies the property isLewdBlurredLayer to have the same value as this.isLewd.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 14, 2023
@prury
Copy link
Member

prury commented May 15, 2023

It seems that the button was not showing properly on mobile as well and your solution fixed it.
Tested on: Firefox and chrome(win), Samsung mobile, Android emulator.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 15, 2023
@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels May 16, 2023
@codeclimate
Copy link

codeclimate bot commented May 16, 2023

Code Climate has analyzed commit c16e627 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented May 16, 2023

pay 20 usd

@yangwao yangwao merged commit 930f042 into kodadot:main May 16, 2023
16 of 19 checks passed
@yangwao
Copy link
Member

yangwao commented May 16, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 25.64 USD/KSM ~ 0.78 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xa7d8d1798d7cb9f3784c643bcc3082ddd22496c055f47abb88386df248a04d55

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full screen button missing
7 participants