Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5853 neo autocomplete #6018

Merged
merged 2 commits into from
May 17, 2023
Merged

#5853 neo autocomplete #6018

merged 2 commits into from
May 17, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented May 17, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
Screen Shot 2023-05-16 at 9 08 14 PM

Copilot Summary

🤖 Generated by Copilot at 3586f9c

Replaced the default autocomplete component with a custom NeoAutocomplete component from the @kodadot1/brick library. This component has better styling and functionality for the SearchBar component. Added some custom styles and a Storybook story for the new component.

🤖 Generated by Copilot at 3586f9c

Sing, O Muse, of the skillful coder who devised
A new component, NeoAutocomplete, to enhance
The search bar of the web app, with custom styles
And stories, extending Oruga's elegance.

@prachi00 prachi00 requested a review from a team as a code owner May 17, 2023 04:08
@prachi00 prachi00 requested review from roiLeo and vikiival and removed request for a team May 17, 2023 04:08
@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b7711d4
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6464b829d3c10e0008c6cd8e
😎 Deploy Preview https://deploy-preview-6018--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 17, 2023

AI-Generated Summary: This pull request introduces a new component called NeoAutocomplete and makes changes to the existing SearchBar.vue component. It adds styles and a story for the new NeoAutocomplete component, and updates the SearchBar.vue component implementation to use the NeoAutocomplete instead of b-autocomplete. Additionally, it exports the NeoAutocomplete component in the index.ts file and makes some minor adjustments to the _search.scss styles.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 17, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@prachi00 prachi00 mentioned this pull request May 17, 2023
37 tasks
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!
✅ wfm

@codeclimate
Copy link

codeclimate bot commented May 17, 2023

Code Climate has analyzed commit b7711d4 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit feb9b04 into main May 17, 2023
19 checks passed
@vikiival vikiival deleted the feat-neo-autoc branch May 17, 2023 12:42
@vikiival
Copy link
Member

pay 30 usd

@yangwao
Copy link
Member

yangwao commented May 17, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 25.52 USD/KSM ~ 1.176 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x88f1fa0007e72fbc6b4b399d7f79a9f368ba7e3c40b5ff164a86b26f6fbfcd38

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 17, 2023
This was referenced May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants