Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 wallet name on first load #6022

Merged
merged 2 commits into from
May 17, 2023
Merged

🔧 wallet name on first load #6022

merged 2 commits into from
May 17, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 17, 2023

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Screenshot 📸

Screenshot 2023-05-17 at 14-03-29 KodaDot - NFT Market Explorer

Copilot Summary

🤖 Generated by Copilot at d8fc24e

The pull request cleans up the WalletAsset component and adds local storage functionality for the wallet name. This enhances the user experience and the maintainability of the code.

🤖 Generated by Copilot at d8fc24e

We've cleaned up the WalletAsset code, me hearties
No more console logs or unused vars to see
We've used a getter for the walletName, so tidy
And stored it in the localStorage, heave ho, heave ho

@roiLeo roiLeo requested a review from a team as a code owner May 17, 2023 12:05
@roiLeo roiLeo requested review from vikiival and daiagi and removed request for a team May 17, 2023 12:05
@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5be72bc
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6464cdf2d3c10e0008c9df20
😎 Deploy Preview https://deploy-preview-6022--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 17, 2023

AI-Generated Summary: This pull request updates the wallet name handling by storing it in the localStorage. It removes unnecessary console logs and modifies the walletName computed property to use a getter from the walletStore. Overall, this change reduces code complexity and enhances the retrieval of the wallet name.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 17, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@daiagi daiagi added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 17, 2023
@yangwao
Copy link
Member

yangwao commented May 17, 2023

and on-chain identity? 👀

@roiLeo
Copy link
Contributor Author

roiLeo commented May 17, 2023

and on-chain identity? 👀

can you be more specific? "roiLeo" is indeed my on-chain Identity

Screenshot 2023-05-17 at 14-34-57 KodaDot - NFT Market Explorer

@roiLeo roiLeo merged commit 1277fc1 into kodadot:main May 17, 2023
11 of 14 checks passed
@codeclimate
Copy link

codeclimate bot commented May 17, 2023

Code Climate has analyzed commit 5be72bc and detected 0 issues on this pull request.

View more on Code Climate.

This was referenced May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants