Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Audio resource #6031

Merged
merged 8 commits into from
May 23, 2023
Merged

🔧 Audio resource #6031

merged 8 commits into from
May 23, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 17, 2023

Tested on /ksm/gallery/15297998-900d19dc7d3c444e4c-PLANETPO-DEEPOLOGIC_PLANET_PO_EP-00000004

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Screenshot 📸

Capture d’écran 2023-05-17 à 5 21 32 PM

Copilot Summary

🤖 Generated by Copilot at 210dd3b

This pull request updates the gallery and search components to handle different media types for NFTs, such as images and animations. It also adds custom icons for NFT collections using the NeoIcon component. It modifies the GalleryItem, useGalleryItem, SearchSuggestion, and useNft files to implement these features.

🤖 Generated by Copilot at 210dd3b

GalleryItem changed
Mapping NFT resources
Debugging in spring

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8b6c342
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646cd23ddd201f00075c38e9
😎 Deploy Preview https://deploy-preview-6031--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added the small Pull request is small label May 17, 2023
@roiLeo roiLeo marked this pull request as ready for review May 17, 2023 15:28
@roiLeo roiLeo requested a review from a team as a code owner May 17, 2023 15:28
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team May 17, 2023 15:28
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

components/gallery/useGalleryItem.ts Outdated Show resolved Hide resolved
@daiagi
Copy link
Contributor

daiagi commented May 17, 2023

Clicking on the full screen button leads to placeholder image (tested on mobile)

Screenshot_2023-05-17-20-33-52-18_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

Screenshot_2023-05-17-20-34-06-30_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

@exezbcz
Copy link
Member

exezbcz commented May 17, 2023

Can we please make the audio file nft preview square 🥺
image

@vikiival
Copy link
Member

Can we please make the audio file nft preview square 🥺

It should show image along with audio?

@exezbcz
Copy link
Member

exezbcz commented May 18, 2023

@vikiival nope, just stretch the container to be square. The next step is this:

@codeclimate
Copy link

codeclimate bot commented May 21, 2023

Code Climate has analyzed commit 2acdd10 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo
Copy link
Contributor Author

roiLeo commented May 21, 2023

Sorry for that I broke my branch
Screenshot 2023-05-21 at 15-17-21 🔧 Audio resource by roiLeo · Pull Request #6031 · kodadot_nft-gallery

Now it looks like this
Screenshot 2023-05-21 at 15-13-57 Deepologic - Planet PO EP KodaDot - NFT Market Explorer

⚠️ I may have break MediaItem view

@exezbcz
Copy link
Member

exezbcz commented May 21, 2023

Now it looks like this

yup, that looks good

@prury
Copy link
Member

prury commented May 23, 2023

rdy for testing?

@roiLeo
Copy link
Contributor Author

roiLeo commented May 23, 2023

rdy for testing?

Always when
Screenshot 2023-05-23 at 16-18-03 🔧 Audio resource by roiLeo · Pull Request #6031 · kodadot_nft-gallery

note: scope here is to update Audio ressource container & remove fullscreen mode for audio

@prury
Copy link
Member

prury commented May 23, 2023

rdy for testing?

Always when Screenshot 2023-05-23 at 16-18-03 🔧 Audio resource by roiLeo · Pull Request #6031 · kodadot_nft-gallery

note: scope here is to update Audio ressource container & remove fullscreen mode for audio

cool cool, hey, working fine on Firefox/Chrome for desktop, but i'm running into some loading issues when using chrome for mobile:

chrome.mp4

@roiLeo
Copy link
Contributor Author

roiLeo commented May 23, 2023

weird it worked for me
Capture d’écran 2023-05-23 à 4 47 55 PM

@roiLeo roiLeo merged commit 2685582 into kodadot:main May 23, 2023
6 checks passed
This was referenced May 25, 2023
@jkdizajn
Copy link

hello, good job! The audio is already working. If it could be:

  1. put there an auto-stop when the second audio starts
  2. cover image could be in the background of the player
firefox_Z1AAZvtiwp.mp4

@exezbcz
Copy link
Member

exezbcz commented May 25, 2023

@jkdizajn Hello sir, have you seen:

Can you please lmk if most of the issues are solved there 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Music Collection is not displayed correctly
8 participants