-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Audio resource #6031
🔧 Audio resource #6031
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
It should show image along with audio? |
@vikiival nope, just stretch the container to be square. The next step is this: |
860dd97
to
2acdd10
Compare
Code Climate has analyzed commit 2acdd10 and detected 0 issues on this pull request. View more on Code Climate. |
yup, that looks good |
rdy for testing? |
hello, good job! The audio is already working. If it could be:
firefox_Z1AAZvtiwp.mp4 |
@jkdizajn Hello sir, have you seen: Can you please lmk if most of the issues are solved there 👀 |
Tested on
/ksm/gallery/15297998-900d19dc7d3c444e4c-PLANETPO-DEEPOLOGIC_PLANET_PO_EP-00000004
PR Type
Context
Before submitting pull request, please make sure:
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 210dd3b
This pull request updates the gallery and search components to handle different media types for NFTs, such as images and animations. It also adds custom icons for NFT collections using the NeoIcon component. It modifies the
GalleryItem
,useGalleryItem
,SearchSuggestion
, anduseNft
files to implement these features.🤖 Generated by Copilot at 210dd3b