Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Simple Option that drives to a non-existent page when using mobile #6033

Merged
merged 2 commits into from
May 18, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 17, 2023

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image

Copilot Summary

🤖 Generated by Copilot at 46f20f7

Removed simple navbar item for Kusama chain. This item is only relevant for the RMRK protocol and the Simple Gallery feature, which are not supported on Kusama.

🤖 Generated by Copilot at 46f20f7

simple navbar item
only for rmrk chain now
autumn leaves falling

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 17, 2023 16:59
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team May 17, 2023 16:59
@kodabot
Copy link
Collaborator

kodabot commented May 17, 2023

SUCCESS @Jarsen136 PR for issue #6028 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 82aa747
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64661ef73c03520008679508
😎 Deploy Preview https://deploy-preview-6033--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 17, 2023

AI-Generated Summary: This pull request fixes the issue where the Simple Option in the CreateDropdown component drives to a non-existent page when using mobile. The change restricts the Simple Option link display to only when the chain is set to 'rmrk', removing it for the 'ksm' case.

@codeclimate
Copy link

codeclimate bot commented May 18, 2023

Code Climate has analyzed commit 82aa747 and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 18, 2023
@vikiival vikiival merged commit 3b6dfa2 into kodadot:main May 18, 2023
19 checks passed
This was referenced May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple Option that drives to a non-existent page when using mobile
4 participants