Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: responsive ModalWrapper content #6035

Merged
merged 1 commit into from
May 18, 2023
Merged

fix: responsive ModalWrapper content #6035

merged 1 commit into from
May 18, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 17, 2023 •
edited

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
image

Copilot Summary

🤖 Generated by Copilot at 987aae5

Improved the responsiveness and layout of the NeoModal component by setting its width to auto in NeoModal.scss.

🤖 Generated by Copilot at 987aae5

Modal adapts
To its content gracefully
Like a spring blossom

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 17, 2023 18:39
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team May 17, 2023 18:39
@kodabot
Copy link
Collaborator

kodabot commented May 17, 2023

SUCCESS @Jarsen136 PR for issue #5975 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 17, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 987aae5
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64651f49be71190007a0ea38
😎 Deploy Preview https://deploy-preview-6035--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 17, 2023

AI-Generated Summary: This pull request includes a change to the NeoModal component's SCSS file, making the ModalWrapper content responsive by adding width: auto to the .o-modal__content class.

@codeclimate
Copy link

codeclimate bot commented May 17, 2023

Code Climate has analyzed commit 987aae5 and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo
roiLeo approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed waiting-for-review labels May 18, 2023
@yangwao
Copy link
Member

yangwao commented May 18, 2023

pay usd 20

@yangwao yangwao merged commit f998bdf into kodadot:main May 18, 2023
20 checks passed
This was referenced May 18, 2023
Merged
Merged
Merged
Merged
@Jarsen136 Jarsen136 mentioned this pull request Aug 5, 2023
Closed
@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5 USD/DOT ~ 4 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x6a6e4fee36bdd182476ae81712ccb32c3b4f9e61121004f3da94b112fb5f35ee

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@roiLeo roiLeo roiLeo approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

responsive ModalWrapper content
5 participants
@Jarsen136 @kodabot @yangwao @preschian @roiLeo