feat: Implement new collection search #6063

Jarsen136 · 2023-05-21T18:06:11Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Context

Closes Implement new collection search into the KodaDot // super charged search #5795
Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality

Optional

I've tested it at </ksm/collection>
I've tested PR on mobile
I've written unit tests 🧪
I've found edge cases

Had issue bounty label?

Fill up your KSM address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

`🤖 Generated by Copilot at ed2282c`

This pull request enhances the search functionality of the NFT gallery by integrating the Polysearch API for collection suggestions and displaying the network name for each collection. It also fixes a bug in the search suggestion component and adds a new chain property to the NFT metadata interface.

`🤖 Generated by Copilot at ed2282c`

To improve the search suggestion view
We use Polysearch API too
We add chain to Metadata
And fix the image path we get
And refactor some code we do

kodabot · 2023-05-21T18:06:16Z

SUCCESS @Jarsen136 PR for issue #5795 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

netlify · 2023-05-21T18:06:19Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`f22d0c8`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/646c9314b7afc30008776b03
😎 Deploy Preview	https://deploy-preview-6063--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

reviewpad · 2023-05-21T18:06:44Z

AI-Generated Summary: This pull request introduces a new collection search feature. It includes the implementation in components/search/utils/collectionSearch.ts and integration with the existing SearchSuggestion.vue component. Furthermore, the patch adds a chain field in the Metadata interface in components/rmrk/service/scheme.ts and updates a URL constant in utils/constants.ts. Overall, the changes consist of 45 insertions and 19 deletions across 4 files.

Jarsen136 · 2023-05-21T18:18:08Z

I have found something missing to implement the new collection search.

For now it shows zero because there's a lack of parts in collections from api: unit and floor price.

API result example:

Would we also like to bring the new collection search into collection explore page? If yes, we need to implement sortBy logic on the api side. Here are the total options of sorts.

It seems that still has not to support searching statemine collection.

cc @vikiival I need your help on the api side.

yangwao · 2023-05-22T09:57:00Z

shows zero because there's a lack of parts in collections from api

we can use skeleton for now and lazy fetch it from subsquid as it was done till now if possible?

Would we also like to bring the new collection search into collection explore page? If yes, we need to implement sortBy logic on the api side. Here are the total options of sorts.

We can do in separate PR

3. It seems that still has not to support searching statemine collection.

separate issue, @vikiival can add these data to be pushed from Stick to there

yangwao · 2023-05-22T10:12:06Z

should work for rmrk2?

on bsx either

vikiival · 2023-05-22T13:00:03Z

Hey @Jarsen136 I will add statemine Collections today but I had to do a smol change

{
  "id": "ksm-3cdf41f721e728d969-VARA",
  "name": "Gear Sub0 Collection",
  "image": "ipfs://ipfs/bafybeidbriqfhzj7cuz2jzcftpmk6czukjd7hunzfnmtpkffzporeee4zy",
  "media_url": "ipfs://ipfs/bafybeidbriqfhzj7cuz2jzcftpmk6czukjd7hunzfnmtpkffzporeee4zy",
  "metadata": "ipfs://ipfs/bafkreifys72uc26xqml5a3k4wbsxol6cbhypxwjikp2liwx3q4brz3i6ka",
  "chain": "ksm",
  "volume": 0,
  "collection_id": "3cdf41f721e728d969-VARA"
}

Id now need to contain chain prefix + collection id
so for routing use collection_id (if you have better naming am open to that)

polygrade workers#91

we can use skeleton for now and lazy fetch it from subsquid as it was done till now if possible?

Yes, please use this

vikiival · 2023-05-22T13:41:38Z

Statemine is there

[
	{
		"id": "stmn-1",
		"name": "Birdboy",
		"image": "ipfs://ipfs/QmaTVEBZtj6m579TuxTHc5dFDWkZXMb4rSDNXw4qVDYjYs",
		"media_url": null,
		"metadata": "ipfs://ipfs/QmeXMHxaaWRAUPAFa9KAuDLmf4w3kSYyWwjw6aDjtKncnW",
		"chain": "stmn",
		"volume": 0,
		"collection_id": "1"
	}
]

Jarsen136 · 2023-05-22T15:29:26Z

Hey @Jarsen136 I will add statemine Collections today but I had to do a smol change
{
  "id": "ksm-3cdf41f721e728d969-VARA",
  "name": "Gear Sub0 Collection",
  "image": "ipfs://ipfs/bafybeidbriqfhzj7cuz2jzcftpmk6czukjd7hunzfnmtpkffzporeee4zy",
  "media_url": "ipfs://ipfs/bafybeidbriqfhzj7cuz2jzcftpmk6czukjd7hunzfnmtpkffzporeee4zy",
  "metadata": "ipfs://ipfs/bafkreifys72uc26xqml5a3k4wbsxol6cbhypxwjikp2liwx3q4brz3i6ka",
  "chain": "ksm",
  "volume": 0,
  "collection_id": "3cdf41f721e728d969-VARA"
}
Id now need to contain chain prefix + collection id so for routing use collection_id (if you have better naming am open to that)

polygrade workers#91

we can use skeleton for now and lazy fetch it from subsquid as it was done till now if possible?

Yes, please use this

Ok, I will check it

Jarsen136 · 2023-05-23T04:03:54Z

should work for rmrk2?

yes

Jarsen136 · 2023-05-23T04:06:08Z

shows zero because there's a lack of parts in collections from api.

we can use skeleton for now and lazy fetch it from subsquid as it was done till now if possible?

✅ Updated

codeclimate · 2023-05-23T10:20:05Z

Code Climate has analyzed commit f22d0c8 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

preschian

is this related? I've got CORS error when I try to search collection

yangwao · 2023-05-23T15:03:45Z

I've got CORS error when I try to search collection

Yes, I think it's related, cc @vikiival

we should add

*-koda-canary.netlify.app
canary.kodadot.xyz
beta.kodadot.xyz
kodadot.xyz

vikiival · 2023-05-24T10:31:13Z

https://deploy-preview-6063--koda-canary.netlify.app

PolySearch Cors on deploy preview workers#93

vikiival · 2023-05-24T10:34:47Z

Uploaded polysearch (3.09 sec)
Published polysearch (1.23 sec)
  https://polysearch.kodadot.workers.dev
Current Deployment ID: 2f514dfa-b1f2-434b-bf7d-20c8d0c21cb7

@Jarsen136 should work now

yangwao · 2023-05-24T10:49:50Z

some works some not, interesting

but on second it fetches fast apparently.

some collections are not there? cc @vikiival

I have zero errors in console.

Do we have some full-text search magic inside/over it?
I think does not match if someone types everything low caps and collection has capital letter in collection name.

yangwao · 2023-05-24T10:53:48Z

pay 50 usd
works, yet I spotted some glitches, maybe bc of workers?

Let's inspect in

Optimize search to search collection with lower caps #6096

yangwao · 2023-05-24T10:54:06Z

pay 50 usd

yangwao · 2023-05-24T10:54:18Z

😍 Perfect, I’ve sent the payout
💵 $50 @ 25.01 USD/KSM ~ 1.999 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x062b7adb929d522dac8b93ba96fe40c39f76d540130432f4fb142e78e2de30de

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

yangwao · 2023-05-24T10:56:25Z

Wrap text when no collection and item is found in search
Mind the mobile version as well to be done well

vikiival · 2023-05-24T11:10:56Z

components/search/SearchSuggestion.vue

+      await Promise.all([
+        ...collectionWithImages.map(async (collection) => {
+          return this.fetchCollectionStats(collection)
+        }),
+      ]).then(() => {
+        this.collectionResult = collectionWithImages
+        this.isCollectionResultLoading = false
+      })


This should be lazyloaded

feat: Implement new collection search

ed2282c

reviewpad bot added the small Pull request is small label May 21, 2023

This was referenced May 22, 2023

Bring supercharged search into collection explore page kodadot/workers#90

Open

Support search Statemine collections kodadot/workers#89

Closed

feat: collection search

cbc0301

Jarsen136 marked this pull request as ready for review May 23, 2023 04:01

Jarsen136 requested a review from a team as a code owner May 23, 2023 04:01

Jarsen136 requested review from preschian and vikiival and removed request for a team May 23, 2023 04:01

reviewpad bot added waiting-for-review medium Pull request is medium and removed small Pull request is small labels May 23, 2023

Jarsen136 and others added 3 commits May 23, 2023 12:08

fix: deepscan issue

c2a2c70

Merge branch 'main' into issue-5795

6898edb

Merge branch 'main' into issue-5795

f22d0c8

preschian reviewed May 23, 2023

View reviewed changes

vikiival mentioned this pull request May 23, 2023

Polysearch has CORS kodadot/workers#92

Closed

yangwao mentioned this pull request May 24, 2023

Optimize search to search collection with lower caps #6096

Closed

yangwao added the paid pull-request has been paid label May 24, 2023

yangwao mentioned this pull request May 24, 2023

Wrap text when no collection and item is found in search #6097

Closed

yangwao merged commit 84d1288 into kodadot:main May 24, 2023
18 of 19 checks passed

vikiival reviewed May 24, 2023

View reviewed changes

This was referenced May 25, 2023

beta update #6105

Merged

release update #6106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement new collection search #6063

feat: Implement new collection search #6063

Jarsen136 commented May 21, 2023 •

edited by yangwao

kodabot commented May 21, 2023

netlify bot commented May 21, 2023 •

edited

reviewpad bot commented May 21, 2023

Jarsen136 commented May 21, 2023 •

edited

yangwao commented May 22, 2023 •

edited

yangwao commented May 22, 2023

vikiival commented May 22, 2023 •

edited

vikiival commented May 22, 2023

Jarsen136 commented May 22, 2023

Jarsen136 commented May 23, 2023

Jarsen136 commented May 23, 2023

codeclimate bot commented May 23, 2023

preschian left a comment

yangwao commented May 23, 2023 •

edited

vikiival commented May 24, 2023

vikiival commented May 24, 2023

yangwao commented May 24, 2023 •

edited

yangwao commented May 24, 2023

yangwao commented May 24, 2023

yangwao commented May 24, 2023

yangwao commented May 24, 2023

vikiival May 24, 2023

feat: Implement new collection search #6063

feat: Implement new collection search #6063

Conversation

Jarsen136 commented May 21, 2023 • edited by yangwao

PR Type

Context

Before submitting pull request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot 📸

Copilot Summary

🤖 Generated by Copilot at ed2282c

🤖 Generated by Copilot at ed2282c

kodabot commented May 21, 2023

netlify bot commented May 21, 2023 • edited

✅ Deploy Preview for koda-canary ready!

reviewpad bot commented May 21, 2023

Jarsen136 commented May 21, 2023 • edited

yangwao commented May 22, 2023 • edited

yangwao commented May 22, 2023

vikiival commented May 22, 2023 • edited

vikiival commented May 22, 2023

Jarsen136 commented May 22, 2023

Jarsen136 commented May 23, 2023

Jarsen136 commented May 23, 2023

codeclimate bot commented May 23, 2023

preschian left a comment

Choose a reason for hiding this comment

yangwao commented May 23, 2023 • edited

we should add

vikiival commented May 24, 2023

vikiival commented May 24, 2023

yangwao commented May 24, 2023 • edited

yangwao commented May 24, 2023

yangwao commented May 24, 2023

yangwao commented May 24, 2023

yangwao commented May 24, 2023

vikiival May 24, 2023

Choose a reason for hiding this comment

Jarsen136 commented May 21, 2023 •

edited by yangwao

`🤖 Generated by Copilot at ed2282c`

`🤖 Generated by Copilot at ed2282c`

netlify bot commented May 21, 2023 •

edited

Jarsen136 commented May 21, 2023 •

edited

yangwao commented May 22, 2023 •

edited

vikiival commented May 22, 2023 •

edited

yangwao commented May 23, 2023 •

edited

yangwao commented May 24, 2023 •

edited