-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ NeoMessage component #6068
✨ NeoMessage component #6068
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AI-Generated Summary: This pull request includes four patches related to the removal of unused components and computed properties in the |
Copy-pasted logic from b-message ? |
Oui. |
|
Low quality effort, it's working but at what cost? |
I don't know maybe it was fixed in another PR, I've just render component in random pages to see if it was working.
In this PR you can test the example: Note: I know it's not looking good, this is a Refactoring PR no design changes has been made. |
Thank you! Apart from the design side then, i found one bug on mobile(resized browser), if you click on the QR code button and leave it open for long enough for the timer to hide the modal, it locks the page scroll. |
Yes! keep in mind this is going to change in (
if you're able to reproduce it on this preview and beta, then we can create a new issue. |
aww its also happening in beta, I'll open a new issue then edit: #6107 |
Code Climate has analyzed commit 6478859 and detected 0 issues on this pull request. View more on Code Climate. |
PR Type
Context
Before submitting pull request, please make sure:
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at f92b398
Refactored the token creation feature to use a custom
NeoMessage
component from the@kodadot1/brick
library instead of the Buefyb-message
component. Deleted unused or redundant components and added documentation and testing for the new component.🤖 Generated by Copilot at f92b398