Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Errors in /collection/:id #6076

Merged
merged 1 commit into from
May 24, 2023
Merged

fix: Errors in /collection/:id #6076

merged 1 commit into from
May 24, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 23, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 09e2b93

This pull request improves the error handling and rendering of the CollectionCard and NeoNftCard components. It adds checks for null or undefined props and handles them gracefully.

🤖 Generated by Copilot at 09e2b93

No more errors in the collection card
We check the prop before we render hard
NeoNftCard is ready for any fight
We handle null and undefined with might

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 23, 2023 04:21
@Jarsen136 Jarsen136 requested review from roiLeo and daiagi and removed request for a team May 23, 2023 04:21
@kodabot
Copy link
Collaborator

kodabot commented May 23, 2023

SUCCESS @Jarsen136 PR for issue #6067 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 23, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 09e2b93
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646c3f68628de00008d3c412
😎 Deploy Preview https://deploy-preview-6076--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 23, 2023
@codeclimate
Copy link

codeclimate bot commented May 23, 2023

Code Climate has analyzed commit 09e2b93 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 23, 2023

AI-Generated Summary: This pull request fixes errors in the /collection/:id route by updating two Vue components, CollectionCard.vue and NeoNftCard.vue. Changes include adding optional chaining for the collection and nft property checks and adjusting the interfaces and default props to make certain properties optional. Total changes include 8 insertions and 8 deletions across the two components.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 23, 2023
@yangwao
Copy link
Member

yangwao commented May 24, 2023

pay 30 usd

@yangwao yangwao merged commit 67af903 into kodadot:main May 24, 2023
18 of 20 checks passed
This was referenced May 25, 2023
@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Aug 8, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 5 USD/DOT ~ 6 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x600183e53c3a58aaaf9f926df1565ed41c77ae231d76ae3711d1e6063b8d38b8

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in /collection/:id
5 participants