Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧑‍💻 label in NeoField is optional #6077

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented May 23, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2023-05-23 at 09 08 30

Screenshot 2023-05-23 at 09 08 34

Copilot Summary

🤖 Generated by Copilot at 3d3f156

Made label prop optional for NeoField component to enable more use cases. Updated NeoInput component and its stories accordingly.

🤖 Generated by Copilot at 3d3f156

NeoField label
optional prop gives freedom
autumn leaves fall off

@vikiival vikiival requested a review from a team as a code owner May 23, 2023 07:12
@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team May 23, 2023 07:12
@netlify
Copy link

netlify bot commented May 23, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3d3f156
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646c67481b61b80008609a96
😎 Deploy Preview https://deploy-preview-6077--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 23, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 23, 2023

AI-Generated Summary: This pull request makes the label prop in the NeoField component optional, allowing the user to use the component without providing a label. The change includes updating the type definition for the label property from string to string?.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 23, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented May 23, 2023

Code Climate has analyzed commit 3d3f156 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 23, 2023
@vikiival vikiival merged commit 0965564 into main May 23, 2023
19 of 20 checks passed
@vikiival vikiival deleted the optional-neo-field branch May 23, 2023 09:29
This was referenced May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants