Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6062 another waifu minter #6083

Merged
merged 16 commits into from
May 23, 2023
Merged

6062 another waifu minter #6083

merged 16 commits into from
May 23, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented May 23, 2023

  • 🎨 rounded radio button
  • 🎨 RadioSelect can be rounded
  • ⚑ rounded
  • 🎨 rounded stepper
  • NONE 🚫
  • 🎨 new cool submit button
  • 🌐 by method
  • β˜€οΈ Split
  • πŸ§‘β€πŸ’» label in NeoField is optional
  • β˜€οΈ Split
  • πŸ› broken steps
  • πŸ› useless mint options
  • 🎨 blue for selection

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

πŸ‘‡ __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests πŸ§ͺ
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot πŸ“Έ

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

πŸ€– Generated by Copilot at 10fd5b8

This pull request adds a new feature for generative minting of NFTs with a Split summer theme, and improves the UI and performance of some components related to this feature. It also makes some minor changes to the NeoField component and the $link-light variable. The main files affected are GenerativeMint.vue, GenerativeMintForm.vue, promptBuilder.ts, and options.ts.

πŸ€– Generated by Copilot at 10fd5b8

Oh we're minting NFTs with a Split summer theme
We've changed the clothes and the styles and the NeoField
On the count of three, we'll pull the rope and see
What the promptBuilder has for us to reveal

@vikiival vikiival requested a review from a team as a code owner May 23, 2023 09:25
@vikiival vikiival requested review from preschian and roiLeo and removed request for a team May 23, 2023 09:25
@netlify
Copy link

netlify bot commented May 23, 2023

βœ… Deploy Preview for koda-canary ready!

Name Link
πŸ”¨ Latest commit 54377c4
πŸ” Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646c88346390fc00080d7e65
😎 Deploy Preview https://deploy-preview-6083--koda-canary.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 23, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 23, 2023

AI-Generated Summary: This pull request includes 13 patches that introduce various visual enhancements and bug fixes. Key changes include adding a rounded radio button, making RadioSelect rounded, updating the GenerativeMintForm with rounded Stepper and modifying the promptBuilder. Additionally, the patches update the generative options, fix broken steps, and change the border color for selection in SelectableImage. Various minor text and display adjustments are also made throughout the components.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 23, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo
Copy link
Contributor

roiLeo commented May 23, 2023

oh no..

@vikiival vikiival mentioned this pull request May 23, 2023
5 tasks
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check #6082 changes to add some code

@vikiival
Copy link
Member Author

Maybe check #6082 changes to add some code

seen, looks amazing sir!

Just would like to have it done since BlockSplit conference is happening (23-25)

@codeclimate
Copy link

codeclimate bot commented May 23, 2023

Code Climate has analyzed commit 54377c4 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit a7e4ff3 into main May 23, 2023
18 of 19 checks passed
@vikiival vikiival deleted the 6062-another-waifu-minter branch May 23, 2023 11:12
@roiLeo roiLeo mentioned this pull request May 24, 2023
This was referenced May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants