Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/tooltip-blocking-events #6085

Merged
merged 2 commits into from
May 24, 2023
Merged

Fix/tooltip-blocking-events #6085

merged 2 commits into from
May 24, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented May 23, 2023 •
edited by yangwao

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

How to test

  1. go to profile page
  2. click on tabs
  3. should change tab as expected

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 95faa61

Improved the behavior and appearance of NeoTooltip components in various places. Added a new prop to control the click event propagation from the tooltip. Fixed an issue where clicking on a disabled tab would switch the tab.

🤖 Generated by Copilot at 95faa61

To improve the profile detail tabs
We tweaked some NeoTooltip props
We added stop-events
And append-to-body makes sense
To avoid some unwanted mishaps

@daiagi daiagi requested a review from a team as a code owner May 23, 2023 12:01
@daiagi daiagi requested review from vikiival and Jarsen136 and removed request for a team May 23, 2023 12:01
@kodabot
Copy link
Collaborator

kodabot commented May 23, 2023

SUCCESS @daiagi PR for issue #6075 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 23, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 95faa61
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646cab130ee56a00082cd418
😎 Deploy Preview https://deploy-preview-6085--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 23, 2023
@codeclimate
Copy link

codeclimate bot commented May 23, 2023

Code Climate has analyzed commit 95faa61 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 23, 2023

AI-Generated Summary: This pull request contains 2 patches:

  1. [PATCH 1/2] conditionally block click events: This patch modifies DisablableTab.vue and NeoTooltip.vue to conditionally block click events when the stopEvents prop is true.

  2. [PATCH 2/2] 🔧 tooltip not showing in profile page tabs: This patch addresses an issue with tooltips not showing in the profile page tabs of ProfileDetail.vue. It adds the append-to-body attribute to the NeoTooltip components to fix the issue.

@daiagi daiagi requested review from preschian and prury and removed request for vikiival May 23, 2023 12:03
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 23, 2023
@prury
Copy link
Member

prury commented May 23, 2023

working fine on:
Desktop: Firefox/Chrome
Mobile: Android Emulator, Android mobile

Jarsen136
Jarsen136 approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 23, 2023
@yangwao
Copy link
Member

yangwao commented May 24, 2023

pay 30 usd

@yangwao yangwao merged commit 0af9739 into main May 24, 2023
20 checks passed
@yangwao yangwao deleted the fix/tooltip-blocking-events branch May 24, 2023 10:28
This was referenced May 25, 2023
Merged
Merged
@daiagi
Copy link
Contributor Author

daiagi commented May 29, 2023 •
edited

@yangwao payout didn't happen. Bot failed I guess
Note payment address is DOT

@yangwao
Copy link
Member

yangwao commented Aug 4, 2023

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Aug 4, 2023

pay 50 usd

fixed payout link

@yangwao
Copy link
Member

yangwao commented Aug 4, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 5.02 USD/DOT ~ 9.96 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x074a0850fcb89fe426556a030bae672e5fa01e3b9c2c508e1600151dfbfd6a3b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@preschian preschian Awaiting requested review from preschian

@prury prury Awaiting requested review from prury

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile Buttons only clickable on sides
5 participants
@daiagi @kodabot @prury @yangwao @Jarsen136