Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸŽ‰ Polkadot for Specific things #6088

Merged
merged 9 commits into from
May 24, 2023
Merged

πŸŽ‰ Polkadot for Specific things #6088

merged 9 commits into from
May 24, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented May 23, 2023

TL;DR

We will be slowly onboarding Kodadot into DOT ecosystem.
So @yangwao asked me to make DOT for transfers

  • πŸ”– static@0.0.3-rc.0
  • πŸ”– static@0.0.3-rc.1
  • πŸ› readonly
  • πŸŽ‰ dot works
  • πŸ”§ disable dot
  • ⚑ hide explorer for dot

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

πŸ‘‡ __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests πŸ§ͺ
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot πŸ“Έ

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2023-05-23 at 16 16 58

Screenshot 2023-05-23 at 16 18 16

Copilot Summary

πŸ€– Generated by Copilot at 9552ece

This pull request adds support for Polkadot as a new chain to the KodaDot app. It updates the @kodadot1/static library and adds the Polkadot constants, endpoints, indexers, and names to the static files. It also adds a feature to hide the explore option in the navbar for chains that do not have a subscan explorer, using a utility function explorerVisible. It disables the create and explore options for Polkadot in the permission config, and adds the dot prefix to the relevant types. It also updates some dependencies in pnpm-lock.yaml and package.json.

πŸ€– Generated by Copilot at 9552ece

We're adding Polkadot to the KodaDot app
@kodadot1/static is the library we tap
We update the endpoints, indexers, and names
We hide the explore option for the chains with no subscan flames

@vikiival vikiival requested a review from a team as a code owner May 23, 2023 14:31
@vikiival vikiival requested review from roiLeo and Jarsen136 and removed request for a team May 23, 2023 14:31
@netlify
Copy link

netlify bot commented May 23, 2023

βœ… Deploy Preview for koda-canary ready!

Name Link
πŸ”¨ Latest commit 4334ea7
πŸ” Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646d141a9ca3b20008ff6c0a
😎 Deploy Preview https://deploy-preview-6088--koda-canary.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels May 23, 2023
dot: false,
}

const hasExplorer: Config<boolean> = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@yangwao
Copy link
Member

yangwao commented May 23, 2023

https://deploy-preview-6088--koda-canary.netlify.app/dot/transfer?target=1KxzJHoRJHi8EgWVhrGDueeyzg8PyihAvSL3NP6QMcxEve6&usdamount=0&donation=true

hmm it generates something πŸ‘€

@yangwao
Copy link
Member

yangwao commented May 23, 2023

I think we should add also showing DOT balances to sidebar

image

@vikiival
Copy link
Member Author

Added in the last commit for KogaDot sir

Screenshot 2023-05-23 at 18 07 18

@yangwao
Copy link
Member

yangwao commented May 23, 2023

Added in the last commit for KogaDot sir

image

lgtm!

@prury
Copy link
Member

prury commented May 23, 2023

@prury prury added the S-works-for-me-βœ… qa-guild has tested PR from end user perspective and functionality worked label May 23, 2023
@roiLeo roiLeo added S-code-lgtm-βœ… code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels May 24, 2023
@codeclimate
Copy link

codeclimate bot commented May 24, 2023

Code Climate has analyzed commit 4334ea7 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 5

View more on Code Climate.

@yangwao yangwao merged commit 161d209 into main May 24, 2023
17 of 19 checks passed
@yangwao yangwao deleted the dot-dot branch May 24, 2023 10:06
@yangwao
Copy link
Member

yangwao commented May 24, 2023

https://polkadot.subscan.io/extrinsic/0xfeba1973d3506809c9f1f046e4f2ccfd19e5604496e19cc52655fea8346d8e03 sent @vikiival $100 seems works!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large S-code-lgtm-βœ… code review guild has reviewed this PR and it's code is approved S-works-for-me-βœ… qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add showing DOT balances to sidebar Add option to use DOT in Transfer
5 participants