Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 for any chain use system token if not specified #6101

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

vikiival
Copy link
Member

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

TL;DR

  • If new chain is added we should expect that default payment method is system token
  • Fix bugs with 'Unit' text

PR Type

  • Bugfix
  • Feature
  • Refactoring

@vikiival vikiival requested a review from a team as a code owner May 24, 2023 15:34
@vikiival vikiival requested review from preschian and Jarsen136 and removed request for a team May 24, 2023 15:34
@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3b55f51
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646e2e9ffdf6460008963b63
😎 Deploy Preview https://deploy-preview-6101--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 24, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 24, 2023

AI-Generated Summary: This pull request modifies utils/api/bsx/query.ts to remove specific token cases 'rmrk', 'ksm', and 'stmn', and updates the default return value to an empty string. As a result, the system token will be used for any chain not specified explicitly.

@codeclimate
Copy link

codeclimate bot commented May 24, 2023

Code Climate has analyzed commit 3b55f51 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 24, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo mentioned this pull request May 25, 2023
2 tasks
@vikiival vikiival merged commit 9b18abd into main May 25, 2023
19 checks passed
@vikiival vikiival deleted the default-token branch May 25, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants