Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back the sort option sn_ASC #6132

Merged
merged 1 commit into from
May 30, 2023
Merged

add back the sort option sn_ASC #6132

merged 1 commit into from
May 30, 2023

Conversation

leo-anderson-x
Copy link
Contributor

@leo-anderson-x leo-anderson-x commented May 29, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Context

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
Screenshot

CleanShot 2023-05-29 at 23 06 16@2x

Copilot Summary

🤖 Generated by Copilot at 272e66e

This pull request adds and updates the translations for the alphabetical sorting option in the gallery for different languages. It also enables the option in the frontend by uncommenting the sn_ASC value in the utils/constants.ts file. This improves the user experience and accessibility of the gallery.

🤖 Generated by Copilot at 272e66e

sn_ASC option
Sorting by alphabet now
Winter of letters

@leo-anderson-x leo-anderson-x requested a review from a team as a code owner May 29, 2023 14:10
@leo-anderson-x leo-anderson-x requested review from preschian and vikiival and removed request for a team May 29, 2023 14:10
@kodabot
Copy link
Collaborator

kodabot commented May 29, 2023

SUCCESS @leo-anderson-x PR for issue #5962 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 272e66e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6474b240db61020008d07b12
😎 Deploy Preview https://deploy-preview-6132--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 29, 2023

AI-Generated Summary: This pull request adds back the sort option sn_ASC and updates the translations for the 'serial number ascending' sort option to 'alphabetically' in German, English, Spanish, French, Portuguese, Russian, and Ukrainian locale files. It also makes a change in the utils/constants.ts file to uncomment the sn_ASC sorting option.

@codeclimate
Copy link

codeclimate bot commented May 29, 2023

Code Climate has analyzed commit 272e66e and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 29, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol
✅ code lgtm
but I don't think Serial Number Ascending means Alphabetically

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 29, 2023
@vikiival
Copy link
Member

Screenshot 2023-05-30 at 12 15 42

lel

@vikiival vikiival merged commit 90dd7e0 into kodadot:main May 30, 2023
19 of 20 checks passed
@prury
Copy link
Member

prury commented May 30, 2023

lol ✅ code lgtm but I don't think Serial Number Ascending means Alphabetically

@vikiival hey, this was merged but as Leo commented it needs to be changed to something other than alphabetically
@leo-anderson-x

@JustLuuuu
Copy link
Member

Check it here: Its not sorting properly: https://deploy-preview-6132--koda-canary.netlify.app/rmrk/collection/08C79124CAC59DC643-BOREDBARRO?collectionId=08C79124CAC59DC643-BOREDBARRO&sort=sn_ASC

Here: 26 is before 25?
Screenshot 2023-06-01 at 12 39 26

Here: absolute mess :D
Screenshot 2023-06-01 at 12 40 53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting by name (serial number)
7 participants