-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add back the sort option sn_ASC
#6132
Conversation
SUCCESS @leo-anderson-x PR for issue #5962 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AI-Generated Summary: This pull request adds back the sort option |
Code Climate has analyzed commit 272e66e and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
✅ code lgtm
but I don't think Serial Number Ascending
means Alphabetically
@vikiival hey, this was merged but as Leo commented it needs to be changed to something other than alphabetically |
Check it here: Its not sorting properly: https://deploy-preview-6132--koda-canary.netlify.app/rmrk/collection/08C79124CAC59DC643-BOREDBARRO?collectionId=08C79124CAC59DC643-BOREDBARRO&sort=sn_ASC |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Community participation
Screenshot 📸
Screenshot
Copilot Summary
🤖 Generated by Copilot at 272e66e
This pull request adds and updates the translations for the alphabetical sorting option in the gallery for different languages. It also enables the option in the frontend by uncommenting the
sn_ASC
value in theutils/constants.ts
file. This improves the user experience and accessibility of the gallery.🤖 Generated by Copilot at 272e66e