Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ init nuxt-simple-sitemap #6133

Merged
merged 4 commits into from
May 30, 2023
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 29, 2023

Closes #6121

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit da22560
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64759b1a0f6a630008d854ef
😎 Deploy Preview https://deploy-preview-6133--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented May 29, 2023

AI-Generated Summary: This pull request consists of two patches that add and configure 'nuxt-simple-sitemap' package for the Nuxt.js project. The first patch includes changes to 'nuxt.config.js' and 'package.json' files, adding the configuration for the sitemap. The second patch removes a static 'sitemap.xml' file, as the new package will handle sitemap generation dynamically.

@reviewpad reviewpad bot added the small Pull request is small label May 29, 2023
@socket-security
Copy link

socket-security bot commented May 29, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@chenfengyuan/vue-qrcode@1.0.0 1.0.2...1.0.0 None +7/-6 chenfengyuan

@yangwao
Copy link
Member

yangwao commented May 29, 2023

@roiLeo
Copy link
Contributor Author

roiLeo commented May 29, 2023

requires Nuxt ^3.3.1

ref #2081, I'll try older version

@reviewpad reviewpad bot added medium Pull request is medium and removed small Pull request is small labels May 29, 2023
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels May 30, 2023
@codeclimate
Copy link

codeclimate bot commented May 30, 2023

Code Climate has analyzed commit da22560 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo
Copy link
Contributor Author

roiLeo commented May 30, 2023

https://deploy-preview-6133--koda-canary.netlify.app/sitemap.xml will improve it after Nuxt3 migration

@roiLeo roiLeo marked this pull request as ready for review May 30, 2023 06:57
@roiLeo roiLeo requested a review from a team as a code owner May 30, 2023 06:57
@roiLeo roiLeo requested review from daiagi and Jarsen136 and removed request for a team May 30, 2023 06:57
@yangwao
Copy link
Member

yangwao commented May 30, 2023

deploy-preview-6133--koda-canary.netlify.app/sitemap.xml will improve it after Nuxt3 migration

and explore pages for items and collections?

@yangwao
Copy link
Member

yangwao commented May 30, 2023

I mean still better than what we have currently out.
Time pimp kodadot seo ride.

@yangwao yangwao merged commit 90a4041 into kodadot:main May 30, 2023
19 checks passed
@roiLeo
Copy link
Contributor Author

roiLeo commented May 30, 2023

and explore pages for items and collections?

will improve it after Nuxt3 migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update KodaDot sitemap generator
3 participants