Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➖ b-table component #6144

Merged
merged 11 commits into from
Jun 14, 2023
Merged

➖ b-table component #6144

merged 11 commits into from
Jun 14, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 1, 2023

What need to be checked

All tables should work

@roiLeo roiLeo requested a review from a team as a code owner June 1, 2023 08:00
@roiLeo roiLeo requested review from preschian and vikiival and removed request for a team June 1, 2023 08:00
@netlify
Copy link

netlify bot commented Jun 1, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 81f7a04
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6489993d34c1d30008883bcb
😎 Deploy Preview https://deploy-preview-6144--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jun 1, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 1, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo requested a review from prury June 1, 2023 08:01
@roiLeo roiLeo mentioned this pull request Jun 1, 2023
Closed
37 tasks
@yangwao
Copy link
Member

yangwao commented Jun 1, 2023

image

feel free to use
https://github.com/kodadot/nft-gallery/blob/main/.github/PULL_REQUEST_TEMPLATE/QUICK_AND_QA_PULL_REQUEST_TEMPLATE.md

@prury
Copy link
Member

prury commented Jun 3, 2023

I'm almost sure I've tackled all of them

is HoTables.vue equivalent to this path? https://deploy-preview-6144--koda-canary.netlify.app/hot/

some minor bugs:

  • scroll appears when hovering on date:
03.06.2023_18.41.04_REC.mp4
  • compared to beta, some tables are slightly closer to the left:
slight.moved.mp4

unrelated: date tool tip being shown under other components

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 3, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 5, 2023

I'm almost sure I've tackled all of them

is HoTables.vue equivalent to this path? https://deploy-preview-6144--koda-canary.netlify.app/hot/

Yup, now fixed.

some minor bugs:

scroll appears when hovering on date:

fixed by changing tooltip position

compared to beta, some tables are slightly closer to the left:

which one?

slight.moved.mp4

Didn't touched item "Activity" table code so it should remain the same as beta

@prury
Copy link
Member

prury commented Jun 5, 2023

I'm almost sure I've tackled all of them
is HoTables.vue equivalent to this path? https://deploy-preview-6144--koda-canary.netlify.app/hot/

Yup, now fixed.

nice!

some minor bugs:
scroll appears when hovering on date:

fixed by changing tooltip position

Still happening, but now i can't see the tooltip unless i scroll down

image

compared to beta, some tables are slightly closer to the left:

which one?

slight.moved.mp4

Didn't touched item "Activity" table code so it should remain the same as beta

The same one as the video was showing(Activity), ok, allright.

@prury
Copy link
Member

prury commented Jun 5, 2023

@roiLeo also happening on the sales tab, but i guess it is part of a bigger problem? #521
mobile also displays the same behavior, i guess the solution on beta was not to show the tool tip when using mobile

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jun 13, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 13, 2023

may I ask review @kodadot/code-review-guild

Jarsen136
Jarsen136 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jun 13, 2023
@vikiival
Copy link
Member

Just wondering: Why it has the light black background behind the table?
is it some design mastery? cc @exezbcz ?

243355111-09f37224-8870-41fa-9a33-cb2958606490

vikiival
vikiival approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE LGTM 🚀

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 14, 2023 •
edited

Just wondering: Why it has the light black background behind the table? is it some design mastery? cc @exezbcz ?

Because table is wrapped inside a .box would you mind sharing link to reproduce it

@codeclimate
Copy link

codeclimate bot commented Jun 14, 2023

Code Climate has analyzed commit 81f7a04 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Jun 14, 2023 •
edited

Just wondering: Why it has the light black background behind the table?

yes this is quite known bug what I've seen, not critical

@yangwao yangwao merged commit 19f6a5d into kodadot:main Jun 14, 2023
18 of 19 checks passed
@roiLeo roiLeo deleted the chore/Buefy/b-table branch June 14, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

@prury prury Awaiting requested review from prury

Assignees
No one assigned
Labels
large Pull request is large S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@roiLeo @yangwao @prury @vikiival @Jarsen136