Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5852 remove buefy tag #6155

Merged
merged 4 commits into from
Jun 7, 2023
Merged

#5852 remove buefy tag #6155

merged 4 commits into from
Jun 7, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jun 2, 2023 •
edited by ghost

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

  • Closes
  • Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
Screen Shot 2023-06-01 at 8 43 39 PM

Copilot Summary

🤖 Generated by Copilot at 4b19b5a

Refactored and restyled the NeoTag component and added a NeoIcon component for better UI.

🤖 Generated by Copilot at 4b19b5a

Oh, we're the crew of the NeoTag ship, and we sail the web so free
We've refactored and restyled our code, to make it look so neat
We've used a div and CSS, to give it some flair and flex
And we've added a NeoIcon too, to close it with a click

@prachi00 prachi00 requested a review from a team as a code owner June 2, 2023 03:45
@prachi00 prachi00 requested review from preschian and daiagi and removed request for a team June 2, 2023 03:45
@netlify
Copy link

netlify bot commented Jun 2, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d5dc980
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64800e7dacea700008e3d1bf
😎 Deploy Preview https://deploy-preview-6155--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 2, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 2, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 2, 2023

AI-Generated Summary: This pull request includes a patch that addresses issue #5852, which involves removing the buefy tag and replacing it with a custom div in NeoTag.vue. The changes include updating the CSS styles to adjust border-radius, background, font-size, and hover effects while introducing the NeoIcon component with an xmark and click event handler for the close functionality.

@prachi00
Copy link
Member Author

prachi00 commented Jun 2, 2023

there are 2 more files where we use <b-tag, but I think those will be deleted its Facts.vue & keyboardhosrtcutsmodal.vue , so didnt change it there

PS. the cross icon in the tag now looks different as we use font awesome icon now

@prachi00 prachi00 requested a review from roiLeo June 2, 2023 03:46
roiLeo
roiLeo suggested changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No darkmode.
Screenshot 2023-06-02 at 08-02-43 Low minting fees and carbonless NFTs KodaDot - NFT Market Explorer

there are 2 more files where we use <b-tag, but I think those will be deleted its Facts.vue & keyboardhosrtcutsmodal.vue , so didnt change it there

In keyboardhosrtcutsmodal replace b-tag with kbd.
Facts is not used, I would remove it.

@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 2, 2023
@roiLeo roiLeo mentioned this pull request Jun 2, 2023
Closed
37 tasks
@prachi00 prachi00 requested a review from roiLeo June 2, 2023 20:16
roiLeo
roiLeo approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

Next we can try to create NeoTag in libs/ui

components/shared/gallery/NeoTag.vue Outdated Show resolved Hide resolved
@roiLeo roiLeo removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 5, 2023
preschian
preschian approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already pointed by roiLeo

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 5, 2023
@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels Jun 6, 2023
@prachi00
Copy link
Member Author

prachi00 commented Jun 7, 2023

can we merge this one?

@codeclimate
Copy link

codeclimate bot commented Jun 7, 2023

Code Climate has analyzed commit d5dc980 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit 8da9164 into main Jun 7, 2023
19 checks passed
@roiLeo roiLeo deleted the feat-neo-tag branch June 7, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@roiLeo roiLeo roiLeo approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prachi00 @preschian @roiLeo @prury