Fix/minting-with-listing--rmrk2 #6156

daiagi · 2023-06-03T14:09:12Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Needs QA check

@kodadot/qa-guild please review

Context

Closes Atributes/Traits not visible in Properties #6149
Closes Minting with Listing - not working properly #6150
🔧 fix (Unreported issue AFAIK) - wrong redirect after mint on RMRK2, it redirected to RMRK
🔧 fix - editions didn't work
✨ when minting multiple nft's (editions) redirect to collection page instead on single nft page
Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

My DOT address: Payout

Screenshot 📸

My fix has changed UI

Testing

Test by mint+list something on RMRK2

Copilot Summary

`🤖 Generated by Copilot at a76663f`

This pull request adds support for the rmrk2 NFT format and improves the user experience of creating and listing NFTs for sale. It updates the CreateToken.vue component, the scheme.ts service, the GalleryItemDescription.vue component, and the types.ts composable to handle the new format and the useTransaction composable. It also fixes some path and naming issues.

`🤖 Generated by Copilot at a76663f`

To support the rmrk2 format
We had to update some code paths
We changed properties
To meta.attributes
And imported a new type from minimark

kodabot · 2023-06-03T14:09:17Z

SUCCESS @daiagi PR for issue #6149 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

netlify · 2023-06-03T14:09:17Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`6ac7787`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/6492f6fa09a9e7000808fd90
😎 Deploy Preview	https://deploy-preview-6156--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kodabot · 2023-06-03T14:09:18Z

SUCCESS @daiagi PR for issue #6150 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

reviewpad · 2023-06-03T14:09:49Z

AI-Generated Summary: This pull request contains two patches:

The first patch fixes a missing attribute issue in the GalleryItem by updating the object property path in GalleryItemDescription.vue. It changes nftMetadata.value?.properties to nftMetadata.value?.meta?.attributes.
The second patch makes several changes related to the listing and redirect on RMRK2 NFTs in the CreateToken.vue component, including:

Updating the listForSale method to accept a single NFT item instead of an array, and switching to using the CreatedNFT or CreatedNFTV2 type from the minimark library, as well as watching the transaction processing status.
Updating the navigateToDetail method to accept an object with nftId and nftName instead of a full CreatedNFT object.
Adding new methods toNFTIdV1 and toNFTIdV2 in scheme.ts, with toNFTIdV2 handling RMRK2 NFTs.
Modifying the toNFTId method to call toNFTIdV1 and toNFTIdV2 depending on whether it's an RMRK 1 or RMRK 2 NFT.

components/rmrk/Create/CreateToken.vue

components/rmrk/service/scheme.ts

components/rmrk/Create/CreateToken.vue

prury · 2023-06-03T21:17:22Z

Testing Process(working properly):

@daiagi thanks for adding a how to test section! ❤️

Signed two transactions, to mint and list.
Added four properties to the minted NFT:

listing ok:

Minted NFT: https://deploy-preview-6156--koda-canary.netlify.app/ksm/gallery/18200581-7EA1DCF47E98A25067-PNKTST-ZOMBIE_GIRL_PUNK-00000005

Extrinsics:
https://kusama.subscan.io/tx/0xcf4baa03b4e05fe7596066629d28943192b3ca9b3c382122980bdc2679062698
https://kusama.subscan.io/tx/0x22a1fbd32f6dbcef47006e9603e9614b1431dc37b88d664fb1c10f911601b990

…x/minting-with-listing--rmrk2

roiLeo · 2023-06-08T09:10:51Z

Testing Process(working properly):

Minted NFT: https://deploy-preview-6156--koda-canary.netlify.app/ksm/gallery/18200581-7EA1DCF47E98A25067-PNKTST-ZOMBIE_GIRL_PUNK-00000005

Shouldn't we have to show key & value instead of Section number?

prury · 2023-06-08T13:43:11Z

Testing Process(working properly):

Minted NFT: https://deploy-preview-6156--koda-canary.netlify.app/ksm/gallery/18200581-7EA1DCF47E98A25067-PNKTST-ZOMBIE_GIRL_PUNK-00000005

Shouldn't we have to show key & value instead of Section number?

Makes sense! good catch!
@daiagi

…x/minting-with-listing--rmrk2

daiagi · 2023-06-09T12:53:39Z

@roiLeo @prury
resolved

KSM:

RMRK:

prury · 2023-06-09T13:32:52Z

@daiagi really good, ty!

…x/minting-with-listing--rmrk2

daiagi · 2023-06-15T00:09:24Z

@vikiival please release new version of minimark

vikiival · 2023-06-15T10:40:04Z

yangwao · 2023-06-15T17:19:50Z

I guess we should wait for this to upcoming release 👀

exezbcz · 2023-06-17T09:06:28Z

@daiagi oki copies, is it

daiagi · 2023-06-18T12:15:33Z

/reviewpad summarize

prury · 2023-06-19T14:35:23Z

@daiagi please lmk when i can check again

vikiival · 2023-06-19T14:50:04Z

I think that you can test it

prury · 2023-06-19T19:15:12Z

Its still showing editions instead of copies.
5 editions test:

https://kusama.subscan.io/tx/0xa576a85f53cc57a5bfbec7a4b7d2163129099e4c351753dba358469ddb760faf
https://kusama.subscan.io/tx/0x9dd8eb22997fa8b7c5a6efffffa4955c9d125d4f5adff9ba4cc7bfa89c4bca1a

Now testing if i can go above the limit:
for this specific collection, i've set a max of 3 nfts to be minted.
https://deploy-preview-6156--koda-canary.netlify.app/ksm/collection/7EA1DCF47E98A25067-3MAX?collectionId=7EA1DCF47E98A25067-3MAX

and then I've tried to mint 10 copies of the first NFT (should be 9 max according to what viki wrote(3/3))
but it did mint the 10 copies, and then it disabled my ability to mint more NFTs in this collection(as expected).

listing occurred as expected

Extrinsics:
https://kusama.subscan.io/tx/0x00c9a44b9c197c705090ceb7bb4994861d169ba5f0662379da14c6cb6b3d0d8d
https://kusama.subscan.io/tx/0x8fc30ff58981ee51d9452d21694471f7e9a372cb6451edd5f15c25690d7528e1
https://kusama.subscan.io/tx/0xb317f9fc46ba65cc7513a25ed5e413ec6c6e9bcb714b8ace2bd4d0ddffb9370a

IMO, on the user side, we should have a input stating how many nfts/copies the user still has left.

…kodadot/nft-gallery into fix/minting-with-listing--rmrk2

…x/minting-with-listing--rmrk2

daiagi · 2023-06-20T05:05:39Z

ts still showing editions instead of copies.

done

Now testing if i can go above the limit:

fixed. it will now mint up to the maximum allowed in the collection

and then I've tried to mint 10 copies of the first NFT (should be 9 max according to what viki wrote(3/3))

i think you misunderstood. if the max of the collection is set to 3 you are suppose to able to mint only up to 3, not 9
#6156 (comment)

IMO, on the user side, we should have a input stating how many nfts/copies the user still has left.

True. but let's push it off to a new issue

prury · 2023-06-20T12:24:31Z

ts still showing editions instead of copies.

done

Now testing if i can go above the limit:

fixed. it will now mint up to the maximum allowed in the collection

ty, will check.

and then I've tried to mint 10 copies of the first NFT (should be 9 max according to what viki wrote(3/3))

i think you misunderstood. if the max of the collection is set to 3 you are suppose to able to mint only up to 3, not 9 #6156 (comment)

oh, you are correct, i did misunderstood, its way simpler than what i have previously tough, thank you daiagi!

IMO, on the user side, we should have a input stating how many nfts/copies the user still has left.

True. but let's push it off to a new issue

will do!

prury · 2023-06-20T12:45:33Z

@daiagi can you give me a hand and test it if you are being able to mint without listing with this deployed version? it won't work here for me, the transaction completes successfully, but no NFT is created.
similar to what is happening on #6245 (comment)

https://kusama.subscan.io/tx/0xdfa6a4a41f4adaaf6b23c3bad425aea45d0259fe6721366c0839fd728269c046

daiagi · 2023-06-20T17:46:14Z

@prury

Sure. I'll check

daiagi · 2023-06-21T05:18:49Z

@prury
Mint w royalty/ w/o listing:

mint w/o royalty w/o listing:

mint 3 copies, w royalties, w properties w/o listing:

mint 2 copies, w list (list would have appeared in the next transaction, but i cancel the minting)

and your own successful mint without listing as well:
https://kusama.subscan.io/extrinsic/18439604-4
https://deploy-preview-6156--koda-canary.netlify.app/ksm/gallery/18439604-7EA1DCF47E98A25067-PNKTST-RADIOACTIVE_PUNK_1-00000006

prury · 2023-06-21T12:30:49Z

Thank you for the many tests!

and your own successful mint without listing as well: https://kusama.subscan.io/extrinsic/18439604-4 https://deploy-preview-6156--koda-canary.netlify.app/ksm/gallery/18439604-7EA1DCF47E98A25067-PNKTST-RADIOACTIVE_PUNK_1-00000006

This one i minted on canary😛

did another one today and it went well:
https://kusama.subscan.io/tx/0xd5d1735f13d4aa784fe79fd642a49eedc4b3e3931e3a0e6fec7b12ae317dc76f

@daiagi last question, will page redirection after minting be done in another PR? otherwise works for me

vikiival · 2023-06-21T12:35:35Z

please resolve conflicts

vikiival · 2023-06-21T12:43:22Z

https://deploy-preview-6156--koda-canary.netlify.app/ksm/gallery/18453986-8cc1b91e899d9be40e-WAIF-TRAVEL_WAIFU_2-00000008

…ing--rmrk2 # Conflicts: # pnpm-lock.yaml

…nft-gallery into fix/minting-with-listing--rmrk2

codeclimate · 2023-06-21T13:11:52Z

Code Climate has analyzed commit 6ac7787 and detected 0 issues on this pull request.

View more on Code Climate.

daiagi added 2 commits June 3, 2023 21:06

fix missing attributed in GalleryItem

1f04eda

🔧 listing and redirect on RMRK2

a76663f

reviewpad bot added the medium Pull request is medium label Jun 3, 2023

daiagi marked this pull request as ready for review June 3, 2023 14:14

daiagi requested a review from a team as a code owner June 3, 2023 14:14

daiagi requested review from vikiival and Jarsen136 and removed request for a team June 3, 2023 14:14

reviewpad bot added the waiting-for-review label Jun 3, 2023

Jarsen136 reviewed Jun 3, 2023

View reviewed changes

components/rmrk/Create/CreateToken.vue Outdated Show resolved Hide resolved

vikiival reviewed Jun 3, 2023

View reviewed changes

components/rmrk/service/scheme.ts Outdated Show resolved Hide resolved

vikiival reviewed Jun 3, 2023

View reviewed changes

components/rmrk/Create/CreateToken.vue Outdated Show resolved Hide resolved

prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 3, 2023

Jarsen136 approved these changes Jun 6, 2023

View reviewed changes

Merge branch 'main' of https://github.com/kodadot/nft-gallery into fi…

cce3588

…x/minting-with-listing--rmrk2

daiagi added 2 commits June 9, 2023 18:13

Merge branch 'main' of https://github.com/kodadot/nft-gallery into fi…

e634313

…x/minting-with-listing--rmrk2

🔧 propeties display

a78bfba

Merge branch 'main' of https://github.com/kodadot/nft-gallery into fi…

67b8e63

…x/minting-with-listing--rmrk2

Merge branch 'main' into fix/minting-with-listing--rmrk2

b08710e

Merge branch 'main' into fix/minting-with-listing--rmrk2

37ee423

daiagi added 4 commits June 20, 2023 11:51

rename edition => copies

4829da9

mint copies up to max of collection

b744e1c

Merge branch 'fix/minting-with-listing--rmrk2' of https://github.com/…

433edb7

…kodadot/nft-gallery into fix/minting-with-listing--rmrk2

Merge branch 'main' of https://github.com/kodadot/nft-gallery into fi…

681c59c

…x/minting-with-listing--rmrk2

roiLeo mentioned this pull request Jun 20, 2023

➖ vuex #6245

Merged

Merge branch 'main' into fix/minting-with-listing--rmrk2

d3d3221

prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 21, 2023

vikiival approved these changes Jun 21, 2023

View reviewed changes

vikiival added 2 commits June 21, 2023 15:11

Merge remote-tracking branch 'origin/main' into fix/minting-with-list…

89440b7

…ing--rmrk2 # Conflicts: # pnpm-lock.yaml

Merge branch 'fix/minting-with-listing--rmrk2' of github.com:kodadot/…

6ac7787

…nft-gallery into fix/minting-with-listing--rmrk2

reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Jun 21, 2023

vikiival merged commit d814faa into main Jun 21, 2023
17 of 19 checks passed

vikiival deleted the fix/minting-with-listing--rmrk2 branch June 21, 2023 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/minting-with-listing--rmrk2 #6156

Fix/minting-with-listing--rmrk2 #6156

daiagi commented Jun 3, 2023 •

edited

kodabot commented Jun 3, 2023

netlify bot commented Jun 3, 2023 •

edited

kodabot commented Jun 3, 2023

reviewpad bot commented Jun 3, 2023

prury commented Jun 3, 2023

roiLeo commented Jun 8, 2023

prury commented Jun 8, 2023 •

edited

daiagi commented Jun 9, 2023 •

edited

prury commented Jun 9, 2023

daiagi commented Jun 15, 2023

vikiival commented Jun 15, 2023

yangwao commented Jun 15, 2023

exezbcz commented Jun 17, 2023

daiagi commented Jun 18, 2023

prury commented Jun 19, 2023

vikiival commented Jun 19, 2023

prury commented Jun 19, 2023 •

edited

daiagi commented Jun 20, 2023

prury commented Jun 20, 2023

prury commented Jun 20, 2023

daiagi commented Jun 20, 2023

daiagi commented Jun 21, 2023

prury commented Jun 21, 2023

vikiival commented Jun 21, 2023

vikiival commented Jun 21, 2023

codeclimate bot commented Jun 21, 2023

Fix/minting-with-listing--rmrk2 #6156

Fix/minting-with-listing--rmrk2 #6156

Conversation

daiagi commented Jun 3, 2023 • edited

PR Type

Needs QA check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

Testing

Copilot Summary

🤖 Generated by Copilot at a76663f

🤖 Generated by Copilot at a76663f

kodabot commented Jun 3, 2023

netlify bot commented Jun 3, 2023 • edited

✅ Deploy Preview for koda-canary ready!

kodabot commented Jun 3, 2023

reviewpad bot commented Jun 3, 2023

prury commented Jun 3, 2023

roiLeo commented Jun 8, 2023

prury commented Jun 8, 2023 • edited

daiagi commented Jun 9, 2023 • edited

KSM:

RMRK:

prury commented Jun 9, 2023

daiagi commented Jun 15, 2023

vikiival commented Jun 15, 2023

yangwao commented Jun 15, 2023

exezbcz commented Jun 17, 2023

daiagi commented Jun 18, 2023

prury commented Jun 19, 2023

vikiival commented Jun 19, 2023

prury commented Jun 19, 2023 • edited

daiagi commented Jun 20, 2023

prury commented Jun 20, 2023

prury commented Jun 20, 2023

daiagi commented Jun 20, 2023

daiagi commented Jun 21, 2023

prury commented Jun 21, 2023

vikiival commented Jun 21, 2023

vikiival commented Jun 21, 2023

codeclimate bot commented Jun 21, 2023

daiagi commented Jun 3, 2023 •

edited

`🤖 Generated by Copilot at a76663f`

`🤖 Generated by Copilot at a76663f`

netlify bot commented Jun 3, 2023 •

edited

prury commented Jun 8, 2023 •

edited

daiagi commented Jun 9, 2023 •

edited

prury commented Jun 19, 2023 •

edited