Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6147 refactor footer #6169

Merged
merged 8 commits into from
Jun 12, 2023
Merged

#6147 refactor footer #6169

merged 8 commits into from
Jun 12, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jun 6, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
Screen Shot 2023-06-05 at 9 04 41 PM

Copilot Summary

@prachi00 prachi00 requested a review from a team as a code owner June 6, 2023 04:04
@prachi00 prachi00 requested review from preschian and Jarsen136 and removed request for a team June 6, 2023 04:04
@kodabot
Copy link
Collaborator

kodabot commented Jun 6, 2023

WARNING @prachi00 PR for issue #6147 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6147

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 85a666b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64856d0ad3bbf60008355ac5
😎 Deploy Preview https://deploy-preview-6169--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 6, 2023

AI-Generated Summary: This pull request includes refactoring of the footer component and deletion of the jobs.vue page. Key changes in the footer component include addition of the "Incentives" section, reordering of items within the "Marketplace" section, and updates to the menuKodadot section. The menuIncentives, menuMarketplace, and menuKodadot objects have been updated accordingly. The jobs.vue page has been removed and replaced by links to the corresponding sections in the footer component.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Jun 6, 2023
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some link on the footer would redirect to incorrect url.

image

@prachi00
Copy link
Member Author

prachi00 commented Jun 6, 2023

Some link on the footer would redirect to incorrect url.

image

oh forgot the external boolean, thanks, fixed it

@prachi00 prachi00 requested a review from Jarsen136 June 6, 2023 05:23
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

components/TheFooter.vue Outdated Show resolved Hide resolved
@preschian preschian requested a review from exezbcz June 6, 2023 06:37
@exezbcz
Copy link
Member

exezbcz commented Jun 6, 2023

the subscribe button is not sizing correctly
image
1082px and around that

same on 850px
image

  • I would maybe switch to mobile footer here

@prury
Copy link
Member

prury commented Jun 6, 2023

According to Exez, the title/links on mobile should be aligned to center:

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 6, 2023
@prachi00
Copy link
Member Author

prachi00 commented Jun 7, 2023

@prury it is already center aligned
Screen Shot 2023-06-06 at 9 27 42 PM

@prachi00
Copy link
Member Author

prachi00 commented Jun 7, 2023

@exezbcz fixed the 1st one
for the 2nd one, it seems mobile view starts at 768px, we use buefy helper for that https://bulma.io/documentation/helpers/visibility-helpers/

@prury
Copy link
Member

prury commented Jun 7, 2023

@prury it is already center aligned Screen Shot 2023-06-06 at 9 27 42 PM

i mean like that:
image

@prachi00
Copy link
Member Author

prachi00 commented Jun 8, 2023

@prury it is already center aligned Screen Shot 2023-06-06 at 9 27 42 PM

i mean like that: image

Screen Shot 2023-06-07 at 9 08 05 PM done

@vikiival
Copy link
Member

vikiival commented Jun 8, 2023

@exezbcz can we merge?

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jun 8, 2023
@yangwao
Copy link
Member

yangwao commented Jun 8, 2023

Documentation -> fix link to developers.kodadot.xyz

  • Documetation should be renamed to "Developers" and point to -> developers.kodadot.xyz
  • Remove Contribute

First Column "Incentives" I would reorganize in following way

Ambassador Program
Artist Ambassador
Referral Program

cc @prachi00

@yangwao yangwao added S-changes-requested-🤞 PR is almost good to go, just some fine tunning and removed S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Jun 8, 2023
@prachi00
Copy link
Member Author

prachi00 commented Jun 8, 2023

Screen Shot 2023-06-08 at 3 42 39 PM
done @yangwao

@prachi00
Copy link
Member Author

@yangwao @vikiival can we merge this

@codeclimate
Copy link

codeclimate bot commented Jun 11, 2023

Code Climate has analyzed commit 85a666b and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit d8276fb into main Jun 12, 2023
18 of 19 checks passed
@vikiival vikiival deleted the feat-footer-refactor branch June 12, 2023 10:57
@vikiival
Copy link
Member

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Jun 12, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.54 USD/DOT ~ 6.608 $DOT
🧗 13Qx65nLd6SwdtjrRyuoEtp9CKXhF651xdHBPaXcvhwKm4N1
🔗 0x7484736c3840c3202a5fcab71966fd5d7f4339a0460fcbc722244ef7cf51910e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning S-visual-ok-✅ waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer reorganization
8 participants