Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unlockable change text in How unlockable item works #6175

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix: Unlockable change text in How unlockable item works #6175

merged 1 commit into from
Jun 6, 2023

Conversation

Jarsen136
Copy link
Contributor

closed #6171

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 6, 2023 12:21
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team June 6, 2023 12:21
@kodabot
Copy link
Collaborator

kodabot commented Jun 6, 2023

SUCCESS @Jarsen136 PR for issue #6171 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jun 6, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5304dde
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/647f24dc1d2c3c00075c5c48
😎 Deploy Preview https://deploy-preview-6175--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 6, 2023

AI-Generated Summary: This pull request updates the text description in the UnlockableContainer.vue component, providing a more engaging and informative explanation of how unlockable items work. Additionally, the "Learn More" button has been changed to an external link, directing users to a related webpage with more information on unlockables.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 6, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 6, 2023

Code Climate has analyzed commit 5304dde and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo
roiLeo approved these changes Jun 6, 2023
View reviewed changes
components/collection/unlockable/UnlockableContainer.vue
Comment on lines +143 to +149
<a
href="https://hello.kodadot.xyz/fandom-toolbox/audience-growth/unlockables"
target="_blank">
<NeoButton variant="unlockable" class="mt-2">
Learn More
</NeoButton>
</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use tag="nuxt-link" & to="https://hello.kodadot.xyz/fandom-toolbox/audience-growth/unlockables" on <NeoButton />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw you can use $t('helper.learnMore')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue to

@yangwao
Copy link
Member

yangwao commented Jun 6, 2023

@yangwao yangwao merged commit f32f4b8 into kodadot:main Jun 6, 2023
18 of 19 checks passed
This was referenced Jun 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangwao yangwao yangwao left review comments

@roiLeo roiLeo roiLeo approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unlockable: change text in How unlockable item works
4 participants
@Jarsen136 @kodabot @yangwao @roiLeo