Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release redesign sidebar menu #6177

Merged
merged 11 commits into from
Jun 15, 2023
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Jun 6, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 5060e79

This pull request refactors and simplifies the layout and logic of the navbar and the connect wallet components. It removes unused code, improves internationalization, and enhances type safety. It also deletes the MobileNavbarProfile.vue file and moves its functionality to the Navbar.vue component.

🤖 Generated by Copilot at 5060e79

We're simplifying the code, me hearties, yo ho ho
We're removing what we don't need, and making it all flow
On the count of three, we'll pull and push, and test it all again
We're simplifying the code, me hearties, for the WalletAsset and the Navbar

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4f01e7f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/648aa410a1255200088a2371
😎 Deploy Preview https://deploy-preview-6177--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 6, 2023

AI-Generated Summary: This pull request, titled "feat: release redesign sidebar menu," focuses on the redesign of the sidebar menu for the KodaDot One Stop Shop for Polkadot NFTs. The commits include various fixes and modifications to the menu, mobile menu adjustments, the implementation of the set identity banner, several merges, and more. Notable changes in the files involve modifications to components such as Navbar.vue, ConnectWallet components, and ProfileDropdown.vue. Additionally, certain files have been added, such as WalletAssetMenu.vue, WalletAssetPortfolio.vue, and WalletAssetSetIdentity.vue, while MobileNavbarProfile.vue has been removed. Various styles have been adjusted, and experimentMixin.ts has also been modified.

@reviewpad reviewpad bot added the large Pull request is large label Jun 6, 2023
@preschian preschian changed the base branch from main to feat/redesign-sidebar-menus June 6, 2023 14:12
Base automatically changed from feat/redesign-sidebar-menus to main June 12, 2023 14:15
@preschian preschian marked this pull request as ready for review June 14, 2023 05:17
@preschian preschian requested a review from a team as a code owner June 14, 2023 05:17
@preschian preschian requested review from roiLeo and daiagi and removed request for a team June 14, 2023 05:17
@preschian preschian requested review from prury and exezbcz June 14, 2023 05:18
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@yangwao
Copy link
Member

yangwao commented Jun 14, 2023

looks really great at me!

cc @exezbcz

image

@prury
Copy link
Member

prury commented Jun 14, 2023

@preschian found something on the language button:

  • when clicked its not triggering the language change on the website
  • if you click on another language, the language menu stays open instead of disappearing(diff from beta)

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 14, 2023
@exezbcz
Copy link
Member

exezbcz commented Jun 14, 2023

lets solve the issue and we are done!

@codeclimate
Copy link

codeclimate bot commented Jun 15, 2023

Code Climate has analyzed commit 4f01e7f and detected 0 issues on this pull request.

View more on Code Climate.

@preschian
Copy link
Member Author

@preschian found something on the language button:

  • when clicked its not triggering the language change on the website
  • if you click on another language, the language menu stays open instead of disappearing(diff from beta)

updated cc @prury @exezbcz

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jun 15, 2023
@yangwao yangwao merged commit 925d94d into main Jun 15, 2023
18 of 19 checks passed
@yangwao yangwao deleted the feat/release-redesign-sidebar-menu branch June 15, 2023 13:55
This was referenced Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile sidebar simplifications // Smart & Simple Assets
5 participants