Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Showing countdown sometimes doesnt show whole row #6178

Merged
merged 3 commits into from
Jun 8, 2023
Merged

fix: Showing countdown sometimes doesnt show whole row #6178

merged 3 commits into from
Jun 8, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jun 6, 2023 •
edited by ghost

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

image

Did your issue had any of the "$" label on it?

Copilot Summary

🤖 Generated by Copilot at 09cb55b

Improved unlockable content slider UI in CountdownTimer.vue by removing margins and adding slides option.

🤖 Generated by Copilot at 09cb55b

CountdownTimer is ticking, the end is near
Unlock the secrets of the keen-slider
No more margins to hold you back, only slides to set you free
Break the chains of the layout, unleash the content you desire

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 6, 2023 16:28
@Jarsen136 Jarsen136 requested review from vikiival and daiagi and removed request for a team June 6, 2023 16:28
@kodabot
Copy link
Collaborator

kodabot commented Jun 6, 2023

SUCCESS @Jarsen136 PR for issue #6172 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jun 6, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c316758
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6481ca8404d1bb00086c1ac4
😎 Deploy Preview https://deploy-preview-6178--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 6, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 6, 2023

AI-Generated Summary: This pull request addresses an issue where the countdown timer sometimes doesn't show the entire row. The changes made involve modifying the CountdownTimer.vue component to adjust the class attribute and adding new properties to the useKeenSlider configuration. Specifically, the slides object has been added with origin, perView, and spacing properties to improve display formatting.

@prury
Copy link
Member

prury commented Jun 7, 2023

@Jarsen136 how to reproduce the bug?

@Jarsen136
Copy link
Contributor Author

@Jarsen136 how to reproduce the bug?

At times on https://canary.kodadot.xyz/stmn/unlockable, the text may appear overlapped or cut off, especially on mobile
image

@prury
Copy link
Member

prury commented Jun 7, 2023

@Jarsen136 how to reproduce the bug?

At times on https://canary.kodadot.xyz/stmn/unlockable, the text may appear overlapped or cut off, especially on mobile image

thank you!
still happening on the deployed version here tho:

image

@Jarsen136
Copy link
Contributor Author

thank you! still happening on the deployed version here tho:

Oh, thanks. I will check it.

@Jarsen136 Jarsen136 marked this pull request as draft June 7, 2023 14:12
@Jarsen136 Jarsen136 marked this pull request as ready for review June 7, 2023 14:26
@Jarsen136 Jarsen136 requested a review from prury June 7, 2023 14:26
@prury
Copy link
Member

prury commented Jun 7, 2023

@Jarsen136

mobile:
image

tablet:
image

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Jun 7, 2023 •
edited

@Jarsen136

mobile: image

tablet: image

Did you reproduce it by adjusting the width of browser windows after the page loaded? It's not responsive right now. I think every time you open the page it displays well without overlapping.

@prury
Copy link
Member

prury commented Jun 7, 2023

Did you reproduce it by adjusting the width of browser windows after the page loaded? It's not responsive right now. I think every time you open the page it displays well without overlapping.

oh, you are right!

image

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 7, 2023
@vikiival
Copy link
Member

vikiival commented Jun 8, 2023

pay 15 usd

@codeclimate
Copy link

codeclimate bot commented Jun 8, 2023

Code Climate has analyzed commit c316758 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Jun 8, 2023

😍 Perfect, I’ve sent the payout
💵 $15 @ 5.01 USD/DOT ~ 2.994 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xf28dcab2baeec575d35733d752a9d80024be4deb3de4802a7ea83c5539db6673

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jun 8, 2023
@vikiival vikiival merged commit fbc4518 into kodadot:main Jun 8, 2023
12 of 14 checks passed
This was referenced Jun 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@daiagi daiagi daiagi approved these changes

@prury prury Awaiting requested review from prury

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showing countdown sometimes doesn't show whole row
6 participants
@Jarsen136 @kodabot @prury @vikiival @yangwao @daiagi