-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: neo dropdown #6196
refactor: neo dropdown #6196
Conversation
AI-Generated Summary: This pull request includes multiple changes across various components, primarily focusing on replacing |
Reviewpad Report
|
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
todos:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hover state in navbar
Enregistrement.de.l.ecran.2023-06-20.a.11.42.21.AM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ wfm
updated |
is there something that can be done about the repeating
|
I think we can replace it by |
cc @preschian ? |
feel free to create a wrapper component for this case. for
use nft-gallery/components/chart/PriceChart.vue Lines 7 to 13 in 475e5e8
in this component, no need nft-gallery/components/common/ConnectWallet/WalletAssetMenu.vue Lines 26 to 29 in 475e5e8
ref: https://vuejs.org/guide/components/slots.html#scoped-slots |
Code Climate has analyzed commit 71485d3 and detected 0 issues on this pull request. View more on Code Climate. |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 934af36
Refactored various components to use custom
NeoDropdown
andNeoDropdownItem
components instead of Buefy components for better UI consistency, accessibility, and performance. Added a new feature to list an NFT directly from the gallery item by passing thenftId
andprice
as parameters. Updated theNeoDropdown
andNeoDropdownItem
components to extend theoruga
library components and allow more customization. Fixed some minor bugs and improved the styling of the dropdown components.🤖 Generated by Copilot at 934af36